Skip to content

Commit e875a41

Browse files
committed
Fix bugs
1 parent a393403 commit e875a41

File tree

7 files changed

+19
-17
lines changed

7 files changed

+19
-17
lines changed

.github/workflows/msvc.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,10 @@ jobs:
402402
-DCMARK_STATIC=ON ^
403403
-DWITH_CMARK=OFF ^
404404
-DWITH_CMARK_GFM=ON ^
405+
-DWITH_WebEngineWidgets=ON ^
406+
-DRABBIT_ENABLE_INSTALL_DEPENDENT=ON ^
407+
-DRABBIT_ENABLE_INSTALL_QT=ON ^
408+
-DRABBIT_ENABLE_INSTALL_TO_BUILD_PATH=ON ^
405409
-DCMAKE_BUILD_TYPE=${{matrix.BUILD_TYPE}} ^
406410
-DCMAKE_INSTALL_PREFIX=${{env.BUILD_DIR}}/install ^
407411
-DCMAKE_PREFIX_PATH=${{env.INSTALL_DIR}} ^
@@ -413,10 +417,6 @@ jobs:
413417
-DVCPKG_TRACE_FIND_PACKAGE=ON ^
414418
-DBUILD_QUIWidget=OFF ^
415419
-DBUILD_APP=ON ^
416-
-DRABBIT_ENABLE_INSTALL_DEPENDENT=ON ^
417-
-DRABBIT_ENABLE_INSTALL_QT=ON ^
418-
-DRABBIT_ENABLE_INSTALL_TO_BUILD_PATH=ON ^
419-
-DWITH_WebEngineWidgets=ON ^
420420
-DBUILD_FREERDP=ON ^
421421
-DPCAP_ROOT=${{env.INSTALL_DIR}}/npcap ^
422422
-DPacket_ROOT=${{env.INSTALL_DIR}}/npcap ^
@@ -427,16 +427,16 @@ jobs:
427427
cmake --install . --config ${{matrix.BUILD_TYPE}} --component DependLibraries --strip
428428
echo "cmake install config: ${{matrix.BUILD_TYPE}} component: Runtime"
429429
cmake --install . --config ${{matrix.BUILD_TYPE}} --component Runtime --strip
430-
echo "cmake install config: ${{matrix.BUILD_TYPE}} component: Application"
431-
cmake --install . --config ${{matrix.BUILD_TYPE}} --component Application --strip
432430
echo "cmake install config: ${{matrix.BUILD_TYPE}} component: Plugin"
433431
cmake --install . --config ${{matrix.BUILD_TYPE}} --component Plugin --strip
432+
echo "cmake install config: ${{matrix.BUILD_TYPE}} component: Application"
433+
cmake --install . --config ${{matrix.BUILD_TYPE}} --component Application --strip
434434
) else (
435435
echo "cmake install config: ${{matrix.BUILD_TYPE}} component: Runtime Application Plugin"
436436
cmake --install . --config ${{matrix.BUILD_TYPE}} --component Runtime
437-
cmake --install . --config ${{matrix.BUILD_TYPE}} --component Application
438437
cmake --install . --config ${{matrix.BUILD_TYPE}} --component Plugin
439438
cmake --install . --config ${{matrix.BUILD_TYPE}} --component DependLibraries
439+
cmake --install . --config ${{matrix.BUILD_TYPE}} --component Application
440440
)
441441
442442
- name: Package

Package/debian/rules

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,12 @@ override_dh_auto_install:
5353
cmake --install $(BUILD_DIR) --config Release \
5454
--component Runtime --strip \
5555
--prefix $(PACKAGE_DIR)/opt/RabbitRemoteControl
56-
cmake --install $(BUILD_DIR) --config Release \
57-
--component Application --strip \
58-
--prefix $(PACKAGE_DIR)/opt/RabbitRemoteControl
5956
cmake --install $(BUILD_DIR) --config Release \
6057
--component Plugin --strip \
6158
--prefix $(PACKAGE_DIR)/opt/RabbitRemoteControl
59+
cmake --install $(BUILD_DIR) --config Release \
60+
--component Application --strip \
61+
--prefix $(PACKAGE_DIR)/opt/RabbitRemoteControl
6262

6363
override_dh_shlibdeps:
6464
dh_shlibdeps --dpkg-shlibdeps-params=--ignore-missing-info -l`pwd`/$(PACKAGE_DIR)/opt/RabbitRemoteControl/lib:`pwd`/$(PACKAGE_DIR)/opt/RabbitRemoteControl/lib/`uname -m`-linux-gnu:$(LIB_PARAS)

Package/rpm/rabbitremotecontrol.spec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,10 @@ cmake --install $RPM_BUILD_DIR --config Release --strip \
113113
--component Runtime \
114114
--prefix ${RPM_BUILD_ROOT}%{INSTALL_PREFIX}
115115
cmake --install $RPM_BUILD_DIR --config Release --strip \
116-
--component Application \
116+
--component Plugin \
117117
--prefix ${RPM_BUILD_ROOT}%{INSTALL_PREFIX}
118118
cmake --install $RPM_BUILD_DIR --config Release --strip \
119-
--component Plugin \
119+
--component Application \
120120
--prefix ${RPM_BUILD_ROOT}%{INSTALL_PREFIX}
121121

122122
#if [ -n "${INSTALL_DIR}" ]; then

Script/build_appimage.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,8 @@ cmake "$REPO_ROOT" \
189189
cmake --build . --config Release --parallel $(nproc)
190190
cmake --install . --config Release --strip --component DependLibraries --prefix ${INSTALL_APP_DIR}
191191
cmake --install . --config Release --strip --component Runtime --prefix ${INSTALL_APP_DIR}
192-
cmake --install . --config Release --strip --component Application --prefix ${INSTALL_APP_DIR}
193192
cmake --install . --config Release --strip --component Plugin --prefix ${INSTALL_APP_DIR}
193+
cmake --install . --config Release --strip --component Application --prefix ${INSTALL_APP_DIR}
194194
if [ -d "${INSTALL_DIR}/share/qtermwidget6" ]; then
195195
cp -r ${INSTALL_DIR}/share/qtermwidget6 ${INSTALL_APP_DIR}/share/
196196
else

Src/Terminal/ParameterTerminal.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ CParameterTerminal::CParameterTerminal(QObject *parent, const QString& szPrefix)
2727
m_bMotionAfterPasting = false;
2828
m_bDisableBracketedPasteMode = false;
2929
m_bDirectional = true;
30-
30+
m_szKeyBindings = "default";
3131
m_szTextCodec = "UTF-8";
3232
m_nHistorySize = 1000;
3333
}

Src/Windows/HookWindows.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,13 +137,14 @@ int CHookWindows::RegisterKeyboard()
137137
msg.checkBox()->setChecked(
138138
m_pParameterPlugin->GetPromptAdministratorPrivilege());
139139
nRet = msg.exec();
140-
if(QMessageBox::Yes == nRet) {
141-
RabbitCommon::CTools::Instance()->StartWithAdministratorPrivilege(true);
142-
}
143140
if(m_pParameterPlugin->GetPromptAdministratorPrivilege()
144141
!= msg.checkBox()->isChecked()) {
145142
m_pParameterPlugin->SetPromptAdministratorPrivilege(
146143
msg.checkBox()->isChecked());
144+
emit m_pParameterPlugin->sigChanged();
145+
}
146+
if(QMessageBox::Yes == nRet) {
147+
RabbitCommon::CTools::Instance()->StartWithAdministratorPrivilege(true);
147148
}
148149
}
149150

snap/snapcraft.yaml.core22

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,7 @@ parts:
300300
- -DWinPR_DIR=$CRAFT_STAGE/usr/local/lib/cmake/WinPR3
301301
- -DFreeRDP-Shadow_DIR=$CRAFT_STAGE/usr/local/lib/cmake/FreeRDP-Shadow3
302302
- -DFreeRDP-Server_DIR=$CRAFT_STAGE/usr/local/lib/cmake/FreeRDP-Server3
303+
- -DWITH_WebEngineWidgets=ON
303304
# build-environment:
304305
# - LD_LIBRARY_PATH: "$CRAFT_STAGE/qt/lib:$LD_LIBRARY_PATH"
305306
# - CMAKE_FIND_ROOT_PATH: "$CRAFT_STAGE/qt;$CRAFT_STAGE/usr/local/lib;$CMAKE_FIND_ROOT_PATH"

0 commit comments

Comments
 (0)