Skip to content

Add optional property labelAfter to set label after drop operation#50

Open
JorgenLindell wants to merge 3 commits into
KarimMokhtar:devfrom
JorgenLindell:dev
Open

Add optional property labelAfter to set label after drop operation#50
JorgenLindell wants to merge 3 commits into
KarimMokhtar:devfrom
JorgenLindell:dev

Conversation

@JorgenLindell
Copy link
Copy Markdown

Summary

Introducing a label to be shown after the drop is completed. Current solution always says "File is uploaded", but in my use case the file should not be uploaded on drop, but rather at a click on a separate button. Then the default text is confusing for the user, as it seems that the upload is already done at that point.

Key Changes

  • add (optional) property labelAfter which is used instead of the default one in case it is defined.

Check List

  • The changes to the "Readme" file(if needed)
  • The changes not breaking any old rule of the library or usage

@KarimMokhtar KarimMokhtar self-requested a review February 21, 2022 21:00
@Victor-Varghese
Copy link
Copy Markdown

@KarimMokhtar can we merge this PR?

@KarimMokhtar
Copy link
Copy Markdown
Owner

@KarimMokhtar can we merge this PR?

Unfortunately, there are required changes that have not been made yet.
If you could make them done it's gonna be great.

@bumi
Copy link
Copy Markdown

bumi commented Aug 22, 2022

pretty please! the "upload another?" text is not matching when the actual submit only happens later and the user has to full out other form fields

@danilloestrela
Copy link
Copy Markdown

danilloestrela commented Dec 19, 2022

@KarimMokhtar what are the requirements needed to finish and merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants