Apply stale-while-revalidate also for responses without a validator#128
Open
mpdude wants to merge 1 commit intoKevinrob:masterfrom
Open
Apply stale-while-revalidate also for responses without a validator#128mpdude wants to merge 1 commit intoKevinrob:masterfrom
mpdude wants to merge 1 commit intoKevinrob:masterfrom
Conversation
Contributor
Author
|
ping @Kevinrob |
Owner
|
Thank @mpdude for this PR! Can you please rebase or merge |
7558984 to
9913c15
Compare
Contributor
Author
|
@Kevinrob rebased, waiting for your feedback. |
Contributor
Author
|
Obviously I'll need to update the tests to reflect changed behaviour; will do once we basically agree. |
Owner
I think the logic is good like that! Can you adapt the tests? |
Owner
|
@mpdude Would you like to rebase this PR and adapt tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to its name, the
stale-while-revalidateCache-Control extension might suggest that it only applies to revalidation requests. However, looking at https://tools.ietf.org/html/rfc5861#section-3...... I see no reason why a cache should not also return a stale response while a complete re-fetch happens in the background (just what would happen if validation fails).
This makes a difference if, for example, a resource has
Cache-Control: public, max-age=30, stale-while-revalidate=30set and no additionalLast-ModifiedorETagheaders.So my suggestion is to re-arrange the conditions slightly. If the client bothers to specify a maximum stale age, we should respect it.