Clarify xrEnumerateInstanceExtensionProperties for API layers #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://registry.khronos.org/OpenXR/specs/1.1/html/xrspec.html#api-initialization , this function *can* be called before calling `xrCreateInstance`. > This function may: be called before an instance has been created; implementations must: not assume an instance exists. Concretely, a bug in past versions of the Ultraleap API layer crashed if an instance had not been created.
|
Related docs PR: KhronosGroup/OpenXR-Docs#173 |
|
An issue (number 2327) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2327 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
|
I think this is a good clarification. I'd be happy for this to be merged. |
fredemmott
added a commit
to fredemmott/HTCC
that referenced
this pull request
Nov 24, 2024
…them If unavailable, should fail with XR_ERROR_EXTENSION_NOT_PRESENT, which can then be handled, and retried. We can't actually reliably check if it's available by any other mechanism given the varied quality of implementations of xrEnumerateInstanceExtensionProperties, and the current spec wording - KhronosGroup/OpenXR-SDK-Source#490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://registry.khronos.org/OpenXR/specs/1.1/html/xrspec.html#api-initialization , this function can be called before calling
xrCreateInstance.Concretely, a bug in past versions of the Ultraleap API layer crashed if an instance had not been created.