layers: Improve err msg for dynamic rendering #10714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 536202. |
|
CI Vulkan-ValidationLayers build # 21045 running. |
|
CI Vulkan-ValidationLayers build # 21045 passed. |
arno-lunarg
force-pushed
the
arno-improve-vu
branch
from
8f2fe52 to
c41afaf
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 536555. |
|
CI Vulkan-ValidationLayers build # 21052 running. |
|
CI Vulkan-ValidationLayers build # 21052 passed. |
| LogError(vuid, cb_state.Handle(), loc, | ||
| "It is invalid to issue this call inside an active render pass instance begun with vkCmdBeginRendering."); | ||
| } else if (cb_state.active_render_pass->use_dynamic_rendering_inherited) { | ||
| LogError(vuid, cb_state.Handle(), loc, |
There was a problem hiding this comment.
Suggested change
| LogError(vuid, cb_state.Handle(), loc, | |
| skip |= LogError(vuid, cb_state.Handle(), loc, |
spencer-lunarg
approved these changes
Sep 23, 2025
arno-lunarg
force-pushed
the
arno-improve-vu
branch
from
c41afaf to
0a79d01
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 537769. |
|
CI Vulkan-ValidationLayers build # 21065 running. |
1 similar comment
|
CI Vulkan-ValidationLayers build # 21065 running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise this code:
m_command_buffer.Begin(); vk::CmdBeginRenderingKHR(m_command_buffer, &rendering_info); //vk::CmdEndRenderingKHR(m_command_buffer); m_command_buffer.End();Will get you this error:
Validation Error: [ VUID-vkEndCommandBuffer-commandBuffer-00060 ] | MessageID = 0x4d08326d
vkEndCommandBuffer(): It is invalid to issue this call inside an active VkRenderPass 0x0.
The Vulkan spec states: If commandBuffer is a primary command buffer, there must not be an active render pass instance (https://docs.vulkan.org/spec/latest/chapters/cmdbuffers.html#VUID-vkEndCommandBuffer-commandBuffer-00060)
Objects: 1
[0] VkCommandBuffer 0x26db64925e0
which is not the best