Skip to content

Perf: Optimize the implementation of IndexIter #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KKould opened this issue Mar 30, 2024 · 1 comment · Fixed by #193
Closed

Perf: Optimize the implementation of IndexIter #190

KKould opened this issue Mar 30, 2024 · 1 comment · Fixed by #193
Assignees
Labels
enhancement New feature or request

Comments

@KKould
Copy link
Member

KKould commented Mar 30, 2024

Feature Request

Currently, the main performance issue: #162 (comment) in the benchmark is the execution of IndexIter

The current implementation of IndexIter is relatively redundant and cumbersome. Its main principle is to use three iterators in order: expression -> index value -> tuple (the primary key is expression -> tuple)
, the current implementation is relatively poor in readability, is there a better implementation?

https://github.com/KipData/FnckSQL/blob/173c39571f560f4b733c8b0608755653ec9dcf50/src/storage/mod.rs#L146-L356

@KKould KKould self-assigned this Mar 30, 2024
@KKould KKould added the enhancement New feature or request label Mar 30, 2024
@KKould
Copy link
Member Author

KKould commented Mar 30, 2024

The previous implementation was temporary. Since Index is now almost complete, I will implement iterators for each index to avoid prediction difficulties caused by a large number of branches.

@KKould KKould closed this as completed Apr 4, 2024
@KKould KKould linked a pull request Apr 4, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant