Skip to content

refactor: optimize the implementation of IndexIter #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2024
Merged

refactor: optimize the implementation of IndexIter #193

merged 2 commits into from
Mar 30, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Mar 30, 2024

What problem does this PR solve?

Abstract the corresponding logic into IndexImpl according to different Indexes

Issue link: #190

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould requested a review from crwen March 30, 2024 14:18
@KKould KKould self-assigned this Mar 30, 2024
@KKould KKould added documentation Improvements or additions to documentation enhancement New feature or request and removed documentation Improvements or additions to documentation labels Mar 30, 2024
@KKould KKould merged commit 28280a4 into KipData:main Mar 30, 2024
3 checks passed
@KKould KKould mentioned this pull request Mar 30, 2024
Open
@KKould KKould linked an issue Apr 4, 2024 that may be closed by this pull request
Perf: Optimize the implementation of IndexIter #190
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwen crwen crwen approved these changes

Assignees

@KKould KKould

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perf: Optimize the implementation of IndexIter
2 participants
@KKould @crwen