Refactor settings to centralized configuration with reusable components#4
Draft
Refactor settings to centralized configuration with reusable components#4
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: KiritoKing <19513548+KiritoKing@users.noreply.github.com>
Deploying yet-another-ffmpeg-webui with
|
| Latest commit: |
f4db091
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a440b135.yet-another-ffmpeg-webui.pages.dev |
| Branch Preview URL: | https://copilot-refactor-settings-si.yet-another-ffmpeg-webui.pages.dev |
…ttingsRenderer Co-authored-by: KiritoKing <19513548+KiritoKing@users.noreply.github.com>
Co-authored-by: KiritoKing <19513548+KiritoKing@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor settings for single source configuration
Refactor settings to centralized configuration with reusable components
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings logic was duplicated across
SettingsDialog.tsx(611 lines) andsettings.tsx(548 lines), violating DRY and making maintenance error-prone.Changes
Configuration Layer
app/config/settings-config.ts: Single source of truth defining all settings metadata, types, and Zustand store bindingsSettingConfig,SettingCategory, andStoreBindinginterfacesComponent Library (
app/components/settings/)SettingSelect,SettingSwitch,SettingButton,SettingCard,SettingStats,SettingCustomSettingsRenderer: Strategy pattern component supporting two rendering modes:mode="dialog": Two-column layout with category navigation (desktop)mode="page": Flat scrollable layout (mobile)Refactored Consumers
SettingsDialog.tsx: 611→104 lines (83% reduction)app/routes/settings.tsx: 548→120 lines (78% reduction)Usage
Desktop dialog:
Mobile route:
Adding new settings requires only config changes:
Impact
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.