Skip to content

segLen should work with sketch segments.#11350

Draft
adamchalmers wants to merge 1 commit into
mainfrom
achalmers/seglen-segs
Draft

segLen should work with sketch segments.#11350
adamchalmers wants to merge 1 commit into
mainfrom
achalmers/seglen-segs

Conversation

@adamchalmers
Copy link
Copy Markdown
Contributor

@adamchalmers adamchalmers commented Apr 28, 2026

Currently segLen(extrude001.sketch.tags.line1) works, but I also think segLen(sketch001.line1) should work too. Currently the latter errors:

  × argument: The input argument of `segLen` requires a value with type
  │ `TaggedEdge`, but found a segment (with type `Segment`).
    ╭─[17:12]
 16 │ // Measure its side lengths
 17 │ side1Len = segLen(sketch001.line1)
    ·            ───────────┬───────────┬
    ·                       │           ╰── tests/seglen_with_segments/input.kcl
    ·                       ╰── tests/seglen_with_segments/input.kcl
 18 │ side2Len = segLen(sketch001.line2)
    ╰────
  ╰─▶ KCL Argument error

Once it works, go back to the KCL book chapter on measuring segments (under fillets.md) and update the examples to use this simpler form.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modeling-app Ready Ready Preview, Comment Apr 28, 2026 5:28pm

Request Review

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 28, 2026

Merging this PR will not alter performance

✅ 115 untouched benchmarks
⏩ 152 skipped benchmarks1


Comparing achalmers/seglen-segs (9f2b1f8) with main (67c1c35)2

Open in CodSpeed

Footnotes

  1. 152 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (c749dcd) during the generation of this report, so 67c1c35 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant