Support distance constraints for higher sketch geometry#11403
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| ))); | ||
| } | ||
|
|
||
| let t = ((point[0] - line_start[0]) * dx + (point[1] - line_start[1]) * dy) / len_sq; |
There was a problem hiding this comment.
I don't understand what this math is actually doing, some comments here would help contextualize this.
There was a problem hiding this comment.
Yeah makes sense. This one is getting an initial solver point for the hidden supporting geometry for a point-line distance constraint, the example I mention in your next comment. I've added some comments here and elsewhere where "datum" or support geometry is added and calculations like this are made.
| }) | ||
| } | ||
|
|
||
| fn circular_circular_support_initial_position( |
There was a problem hiding this comment.
What is the point of all this "initial" stuff? Is it so that when users hit the distance constraint, the constraint is initially set to the current distance between the two geometry, and the user can edit it later?
There was a problem hiding this comment.
Nah all these new distance variants rely on hidden constraint inputs: like the point-line distance uses a hidden line coincident with the line and the point for example, and constrains it to be perpendicular to the target line. These helpers provide initial values to those hidden "lowering" geometries to ensure they're solved in the expected orientation.
There was a problem hiding this comment.
The point-line lowering for example, is here https://github.com/KittyCAD/modeling-app/tree/franknoirot/adhoc/distance-constraint-pairs/rust/kcl-lib/src/execution/exec_ast.rs#L3620-L3633, I've added comments to each of them to describe the support geometry they use.
| | (UnsolvedSegmentKind::Circle { .. }, UnsolvedSegmentKind::Point { .. }) => { | ||
| (unsolved1, unsolved0) | ||
| } | ||
| _ => unreachable!(), |
There was a problem hiding this comment.
Please don't put unreachable!() in, it leads to panics which are hard to figure out later in production. If you really, really have to panic, please put a unique error message. But instead it's better to return a proper KclError, or structure the match so that this error state is impossible.
Same for the unreachable!()s below.
There was a problem hiding this comment.
Ah yup apologies, I've correct it here and added a note to the Rust AGENTS.md if that's cool with you.
Merging this PR will not alter performance
Comparing 
Footnotes
|
2 participants
Adds distance constraints for point-line, line-line, point-arc/circle, line-arc/circle, and arc/circle pairs by lowering them into supported solver constraints with hidden construction geometry where needed.
Also preserves labelPosition across the new lowered distance variants, updates point-and-click distance previews/annotations, and keeps non-parallel line-line point-and-click behavior falling back to angle constraints while KCL distance lowering remains available.
Here is a list of how each lowering works, with some diagrams:
point-line: create a hidden support point on the line, make the segment from the point to that support point perpendicular to the line, then constrain that segment length.
line-line: force the lines parallel, pick a point on one line, create a hidden support point on the other line, make the connecting segment perpendicular, then constrain its length.
point-circular: create a hidden circle centered on the point with radius equal to the requested distance, then make it exterior-tangent to the target arc/circle.
line-circular: create a hidden support point on the line at the projection of the circular center, make that support segment perpendicular to the line, then use the point-circular lowering from the support point.
circular-circular: create a hidden spacer circle with radius
distance / 2, constrain its center onto the line between the two circular centers, then make it exterior-tangent to both target circular geometries.Demo
Screenshare.-.2026-05-02.1_04_20.AM-compressed.mp4