Skip to content

Conversation

franknoirot
Copy link
Contributor

Some chore work that will help me in some design token / design system work I'm exploring right now.

  1. followed the Tailwind upgrade guide and used their upgrade tool
  2. had to tweak some stuff and re-run the tool because it errored on a couple points
  3. had to add @references to our *.module.css files per this page. I wish I could use our @src alias here but it looked like I could only use relative syntax
  4. I had to correct a couple places where the upgrade tool moved things into @utilitys or @layer utilities where it was inappropriate. The biggest was the selectors around the #codemirror-overrides ID. I decided to just move these into their own file and @import them at the top of the index.css file while I was making the change.

The idea here is that nothing should break or look visually wrong after this migration. Please help me scour the app to find any other styles that appear broken before this merges.

By running `npx @tailwindcss/upgrade`, then fixing `*.module.css` files
that had no `@reference` which is a new thing, then moving the
code-mirror override selectors and a few other things out of the utility
layer that the migration script moved them into. Sorry it's all in one
commit, the first script touched so many files I should have committed
immediately.
@franknoirot franknoirot requested a review from a team as a code owner August 14, 2025 23:47
Copy link

vercel bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
modeling-app Ready Preview Comment Aug 15, 2025 5:55am

@franknoirot franknoirot marked this pull request as draft August 14, 2025 23:57
@franknoirot
Copy link
Contributor Author

Found a couple gotchas with border-radii on the home page project cards, and in the status bar something fiddly is off with the help menu button. These point toward a couple spots where the migration might not have worked quite right; needs more of a comb-through before I mark as ready.

@jacebrowning
Copy link
Contributor

The styling is off on these dialogs in the Vercel preview:

Screenshot 2025-08-15 at 3 04 23 PM

@max-mrgrsk
Copy link
Contributor

dropdown menu buttons got borders, but the file button lost it:

Screenshot 2025-08-19 at 15 39 30

before:

Screenshot 2025-08-19 at 15 39 38

@franknoirot
Copy link
Contributor Author

Thank you for these @jacebrowning and @max-mrgrsk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants