-
Notifications
You must be signed in to change notification settings - Fork 87
Add minimum sketch block AST and parsing #8171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jtran
wants to merge
17
commits into
main
Choose a base branch
from
jtran/sketch-ast
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CodSpeed Instrumentation Performance ReportMerging #8171 will not alter performanceComparing Summary
|
c483bf3
to
5385613
Compare
jtran
commented
Aug 29, 2025
Comment on lines
+48
to
+55
fn recast_body( | ||
items: &[BodyItem], | ||
non_code_meta: &NonCodeMeta, | ||
inner_attrs: &NodeList<Annotation>, | ||
buf: &mut String, | ||
options: &FormatOptions, | ||
indentation_level: usize, | ||
) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code in this function didn't change semantically. I just factored it out to a function.
d8a40ed
to
0f817da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8185.
Adds a new AST node type called
SketchBlock
and parsing it the same as a function call, followed by a curly brace delimited block. This intentionally reuses existing code. This PR doesn't add any other new sketch block parsing features likevar
or==
.Both parse and execution warnings are generated. You can use
@settings(experimentalFeatures = allow)
to turn them off.Execution isn't done. Even evaluating arguments isn't done.
I've used the string
TODO: sketch-api:
to indicate things that we should come back to.This should make #4015 easier.