Merge pull request #2551 from DavidBerger98/fix-stackoverflow-clipclosedsurface

finetjul · web-flow · commit 62e5140c2c73 · 2022-08-16T16:56:51.000+02:00
fix(vtkClipClosedSurface): Fix stack overflow when inputPolys.getCellSizes() is too big
diff --git a/Sources/Filters/General/ClipClosedSurface/index.js b/Sources/Filters/General/ClipClosedSurface/index.js
@@ -799,8 +799,7 @@ function vtkClipClosedSurface(publicAPI, model) {
       );
 
       // Check if the input has polys and quads or just triangles
-      // TODO: Improve performance
-      polyMax = Math.max(...inputPolys.getCellSizes());
+      polyMax = inputPolys.getCellSizes().reduce((a, b) => (a > b ? a : b), 0);
     }
 
     // Arrays for storing the clipped lines and polys

Original file line number	Diff line number	Diff line change
`@@ -799,8 +799,7 @@ function vtkClipClosedSurface(publicAPI, model) {`
`799`	`799`	`);`
`800`	`800`
`801`	`801`	`// Check if the input has polys and quads or just triangles`
`802`		`- // TODO: Improve performance`
`803`		`- polyMax = Math.max(...inputPolys.getCellSizes());`
	`802`	`+ polyMax = inputPolys.getCellSizes().reduce((a, b) => (a > b ? a : b), 0);`
`804`	`803`	`}`
`805`	`804`
`806`	`805`	`// Arrays for storing the clipped lines and polys`