-
-
Notifications
You must be signed in to change notification settings - Fork 393
feat(objwriter): add support for vtkOBJWriter #2405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daker
wants to merge
1
commit into
Kitware:master
Choose a base branch
from
daker:add-objwriter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jourdain
reviewed
May 8, 2022
68353a6
to
175a919
Compare
jourdain
approved these changes
May 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
finetjul
reviewed
May 9, 2022
finetjul
reviewed
May 9, 2022
finetjul
reviewed
Dec 20, 2024
7addc1e
to
de494f4
Compare
c5fbfac
to
db7d26b
Compare
I'm ok with the code, knowing that there is some limitation in the current implementation as only one texture can exist. |
jourdain
approved these changes
Jun 1, 2025
@floryst ready for a merge 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2404
Context
Add support for vtkOBJWriter
Results
Changes
PR and Code Checklist
npm run reformat
to have correctly formatted codeTesting