ENH: Move itk::PhasedArray3DSpecialCoordinatesImage to ITK core #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Maybe @thewtex can comment on the ITK pre-release schedule? |
|
Converting to draft, so we don't accidentally merge it before packages are ready. |
|
Excellent! The wrapping for PhasedArray3DSpecialCoordinatesImage will be in itk-5.4rc2. Let's update this repository to v5.4rc1 first. |
dzenanz
added a commit
to dzenanz/ITKUltrasound
that referenced
this pull request
Jul 12, 2023
Remove itk::PhasedArray3DSpecialCoordinatesImage wrapping from: InsightSoftwareConsortium/ITK#4101 Closes KitwareMedical#234.
dzenanz
added a commit
to dzenanz/ITKUltrasound
that referenced
this pull request
Jul 12, 2023
Remove itk::PhasedArray3DSpecialCoordinatesImage wrapping from: InsightSoftwareConsortium/ITK#4101 Closes KitwareMedical#234.
dzenanz
added a commit
to dzenanz/ITKUltrasound
that referenced
this pull request
Jul 14, 2023
Remove itk::PhasedArray3DSpecialCoordinatesImage wrapping from: InsightSoftwareConsortium/ITK#4101 Closes KitwareMedical#234.
dzenanz
added a commit
to dzenanz/ITKUltrasound
that referenced
this pull request
Jul 14, 2023
Remove itk::PhasedArray3DSpecialCoordinatesImage wrapping from: InsightSoftwareConsortium/ITK#4101 Closes KitwareMedical#234.
Remove itk::PhasedArray3DSpecialCoordinatesImage wrapping from: InsightSoftwareConsortium/ITK#4101 Closes KitwareMedical#234.
dzenanz
force-pushed
the
removePA3DSCI
branch
2 times, most recently
from
bdad7fa to
fb65709
Compare
dzenanz
force-pushed
the
removePA3DSCI
branch
from
fb65709 to
863e004
Compare
dzenanz
force-pushed
the
removePA3DSCI
branch
from
181d701 to
cbdf24e
Compare
|
Converting to draft until I resolve Python packaging issues, which I can now reproduce locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires ITK python package with itk::PhasedArray3DSpecialCoordinatesImage wrapping added in: InsightSoftwareConsortium/ITK#4101.
Supersedes and closes #237.