-
-
Notifications
You must be signed in to change notification settings - Fork 47
Feat/add user token test #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hasnain095
wants to merge
13
commits into
Kludex:main
Choose a base branch
from
hasnain095:feat/add-user-token-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
286693e
Added test for user token
ff1fa7b
scoped the create_non_superuser test to session
0b150ad
fixed default argument, fixed no new line lint error
37e941c
fixed fixture scope
0d8fe92
fix for test failing due to fixture scope mismatch
063d679
Merge pull request #3 from Kludex/main
hasnain095 b68e839
removed fixture session scope
59362cc
Merge branch 'feat/add-user-token-test' of github.com:hasnain095/fast…
76e806e
fixed fixture scoping
43d5267
removed fixture session scopes
eabf791
changed dummy password in test
95d4bf4
removed conditional because we roll back, its not required
0cc7353
removed unused imports
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,18 @@ | ||
import asyncio | ||
from typing import Dict | ||
from typing import Dict, Optional | ||
|
||
import pytest | ||
from asgi_lifespan import LifespanManager | ||
from httpx import AsyncClient | ||
from sqlalchemy import select | ||
from sqlalchemy.ext.asyncio import AsyncConnection, AsyncSession | ||
|
||
from app.api.deps import get_session | ||
from app.core.security import get_password_hash | ||
from app.core.config import settings | ||
from app.core.database import engine | ||
from app.main import app | ||
from app.models.users import User | ||
|
||
|
||
@pytest.fixture() | ||
|
@@ -53,3 +56,27 @@ async def superuser_token_headers(client: AsyncClient) -> Dict[str, str]: | |
res = await client.post("/api/v1/login/", data=login_data) | ||
access_token = res.json()["access_token"] | ||
return {"Authorization": f"Bearer {access_token}"} | ||
|
||
|
||
@pytest.fixture() | ||
async def create_non_superuser(session: AsyncSession, scope="session") -> Dict[str, str]: | ||
email = "test_user@test.com" | ||
password = "Ksd8nASD1_Hjns!P" | ||
hashed_password = get_password_hash(password) | ||
result = await session.execute(select(User).where(User.email == email)) | ||
user: Optional[User] = result.scalars().first() | ||
if user is None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is never going to happen cause there will be a rollback on each test. Sorry, I didn't notice before. |
||
session.add(User(email=email, hashed_password=hashed_password, is_superuser=False)) | ||
await session.commit() | ||
return {"email": email, "password": password} | ||
|
||
|
||
@pytest.fixture() | ||
async def user_token_headers(client: AsyncClient, create_non_superuser: Dict[str, str]) -> Dict[str, str]: | ||
login_data = { | ||
"username": create_non_superuser["email"], | ||
"password": create_non_superuser["password"], | ||
} | ||
res = await client.post("/api/v1/login/", data=login_data) | ||
access_token = res.json()["access_token"] | ||
return {"Authorization": f"Bearer {access_token}"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be a
scope="session"
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Facing an issue when changing this fixture's scope to "session", the user_token_header fixture is function scoped and causes a ScopeMismatch error. If we set the scope of user_token_header as "session" too, then it causes an issue with accessing the "function" scoped fixture "client" with "session" scoped fixture "create_non_superuser".
My opinion is to create a class, and scope all related fixtures to "class". This way we can add any test related to the users into that class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The client fixture can be session as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That leads to making the "session" and "connection" fixtures be scoped to the session. I've made these changes already, and all tests passed.