-
Notifications
You must be signed in to change notification settings - Fork 237
Replace proprietary dependencies with open source #3065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Replace proprietary dependencies with open source #3065
Conversation
Co-authored-by: charl <charl@vanstaden.info>
Cursor Agent can help with this pull request. Just |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
log( | ||
'Analytics collection disabled', | ||
path: 'analytics -> FirebaseAnalyticsService -> deactivate', | ||
path: 'analytics -> MatomoAnalyticsService -> deactivate', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Matomo Analytics Ignores User Opt-Out
The MatomoAnalyticsRepo
fails to properly enforce user analytics opt-out preferences. Unlike the previous Firebase implementation which disabled collection at the SDK level via setAnalyticsCollectionEnabled(false)
, the current Matomo integration does not call MatomoTracker.instance.setOptOut(true)
when analytics are deactivated. This allows direct calls to sendData
to bypass the internal _isEnabled
check and transmit analytics events even when the user has opted out, leading to a privacy violation.
Additional Locations (1)
Co-authored-by: charl <charl@vanstaden.info>
Replace Firebase analytics with Matomo to comply with F-Droid open-source requirements.