Skip to content

Conversation

@CharlVS
Copy link
Member

@CharlVS CharlVS commented Oct 12, 2025

Summary

  • add an app-level configuration flag to control icon precaching
  • guard the coin icon precache routine behind the new configuration toggle

Testing

  • flutter analyze (fails: The current Flutter SDK version is 3.32.5 but web_dex requires >=3.35.3)

https://chatgpt.com/codex/tasks/task_e_68e940bbbf80832693076aa4d39dc72e


Note

Introduce isIconPrecachingEnabled (default false) and conditionally run coin icon precaching in didChangeDependencies().

  • Config:
    • Add isIconPrecachingEnabled (default false) in lib/app_config/app_config.dart to control asset icon precaching.
  • App lifecycle:
    • Guard _precacheCoinIcons(...) in _MyAppViewState.didChangeDependencies() behind isIconPrecachingEnabled.

Written by Cursor Bugbot for commit 442140a. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/add-config-flag-for-icon-precaching

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 442140a):

https://walletrc--pull-3176-merge-if5snysy.web.app

(expires Sun, 19 Oct 2025 12:09:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@smk762
Copy link
Collaborator

smk762 commented Oct 13, 2025

Can you please mention the problem (or issue) this PR aims to solve, along with measurable test (if possible) to confirm it is solved?

@CharlVS CharlVS marked this pull request as draft October 13, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants