Support feature selection for device#406
Open
koubaa wants to merge 10 commits intoKomputeProject:masterfrom
Open
Support feature selection for device#406koubaa wants to merge 10 commits intoKomputeProject:masterfrom
koubaa wants to merge 10 commits intoKomputeProject:masterfrom
Conversation
added 3 commits
December 10, 2024 09:33
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
koubaa
changed the title
added 5 commits
December 10, 2024 10:34
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
Contributor
Author
|
I can't figure out why the python test is crashing. It works on my machine™ |
Signed-off-by: koubaa <koubaa@github.com>
Closed
axsaucedo
requested changes
Apr 13, 2026
Member
axsaucedo
left a comment
axsaucedo
left a comment
There was a problem hiding this comment.
Thanks, but there's a few additions and changes that I'm not clear why are there - please revisit
| numpy==1.22.4 | ||
| pytest==7.1.2 | ||
|
|
||
| pytest-forked==1.6.0 |
| * physicalDevice | ||
| */ | ||
| Manager(uint32_t physicalDeviceIndex, | ||
| const vk::PhysicalDeviceFeatures& desiredFeatures, |
Member
There was a problem hiding this comment.
Why do we need another constructor instead of just adding a new optional param to the previous constructor?
| } | ||
| #endif | ||
|
|
||
| static void setUpLogger() { |
|
|
||
| test_python: | ||
| python3 -m pytest -s --log-cli-level=DEBUG -v python/test/ | ||
| python3 -m pytest --forked -s --log-cli-level=DEBUG -v python/test/ |
| } | ||
|
|
||
| kp::Manager mgrAsync(0, { 0, 2 }); | ||
| kp::Manager mgrAsync(0, std::vector<uint32_t>{ 0, 2 }); |
| } | ||
|
|
||
| Manager::Manager() | ||
| : Manager(0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered the following error
So I added the ability to 1) report the available features and 2) request features when creating the device.