fix: Show OAuth redirection params error details in MCP OAuth error#9587
Merged
Conversation
✅ Circular References ReportGenerated at: 2026-03-06T10:05:39.546Z Summary
Click to view all circular references in PR (76)Click to view all circular references in base branch (76)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
c467ac5 to
25785b2
Compare
ZxBing0066
reviewed
Jan 27, 2026
fdd2865 to
61bf1bc
Compare
ryan-willis
approved these changes
Feb 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Improves MCP developer tooling around OAuth failures and event JSON rendering, aiming to make MCP auth failures easier to diagnose and MCP event payloads easier to inspect.
Changes:
- Parse OAuth redirect query parameters (
error,error_description,error_uri) and surface them via the thrown error when redirect indicates an OAuth error. - Enhance the MCP event JSON preview to parse nested JSON strings during prettification.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/insomnia/src/ui/components/mcp/event-view.tsx | Adds a JSON.parse reviver to coerce nested JSON-encoded strings into structured objects for the preview panel. |
| packages/insomnia/src/main/mcp/oauth-client-provider.ts | Extracts OAuth redirect error params and throws an error when the redirect contains an OAuth error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
ZxBing0066
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: