refactor: use function instead of an object for create nedb#9594
Merged
Conversation
✅ Circular References ReportGenerated at: 2026-03-06T07:34:56.130Z Summary
Click to view all circular references in PR (76)Click to view all circular references in base branch (76)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
ZxBing0066
changed the base branch from
refactor/insomnia-data-folder
to
develop
ZxBing0066
force-pushed
the
refactor/create-nedb-database
branch
from
6547665 to
14fb8ea
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the NeDB-backed database implementation to be created via a factory function rather than exported as a singleton object, and extracts the database repair logic into its own module. This aligns the Node/main-process database implementation with a more explicit construction/wrapping pattern.
Changes:
- Replaced the
nedbDatabaseexported object with acreateNedbDatabase()factory (with an optional wrapper hook). - Extracted database repair routines into
repair-database.tsand updated tests accordingly. - Updated main process + in-memory send-request initialization to use
createNedbDatabase().
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/insomnia/src/main/database.main.ts | Uses createNedbDatabase() wrapper to customize init and flushChanges in the Electron main process. |
| packages/insomnia/src/insomnia-data/node-src/index.ts | Switches node entrypoint export from nedbDatabase to createNedbDatabase. |
| packages/insomnia/src/insomnia-data/node-src/database/repair-database.ts | New standalone module containing the database repair routines. |
| packages/insomnia/src/insomnia-data/node-src/database/database.test.ts | Updates repair-related tests to call repairDatabase() from the new module. |
| packages/insomnia/src/insomnia-data/node-src/database/database-nedb.ts | Core refactor: introduces createNedbDatabase() factory and imports repairDatabase. |
| packages/insomnia/src/common/send-request.ts | Initializes an in-memory DB for send-request via createNedbDatabase(). |
| packages/insomnia/src/common/database.ts | Adds a small re-export module for database + related types. |
Comments suppressed due to low confidence (1)
packages/insomnia/src/insomnia-data/node-src/database/database-nedb.ts:560
createNedbDatabase()is now a factory, but the backing state (nedbBucket,bufferingChanges,changeBuffer,changeListeners, etc.) is still module-scoped. That means multiple database instances created via this factory will share state and can interfere with each other (e.g., listeners/buffers leaking across instances, one init overwriting another instance’s buckets). Consider moving this state insidecreateNedbDatabase()(or otherwise keying it per instance) so each created database is actually isolated, or explicitly document/enforce that only a single instance may exist per process.
let nedbBucket: Record<AllTypes, NeDB> = {} as Record<AllTypes, NeDB>;
// ~~~~~~~~~~~~~~~~ //
// Change Listeners //
// ~~~~~~~~~~~~~~~~ //
let bufferingChanges = false;
let bufferChangesId = 1;
let changeBuffer: ChangeBufferEvent[] = [];
let changeListeners: ChangeListener[] = [];
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CurryYangxx
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In the previous commit, the database was an object that inherits the database-nedb, now update it to be a create function to be more reasonable.
Changes