-
Notifications
You must be signed in to change notification settings - Fork 110
Update dependencies and clean up build scripts #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FenstonSingel
wants to merge
6
commits into
master
Choose a base branch
from
kotlin-community/build-scripts-cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
90dcbfb
Bump Gradle version to 8.9
FenstonSingel fd315d9
Bump Kotlin version to 2.0.10
FenstonSingel e2c0d4e
Remove old infrastructure for builds as a Kotlin user project
FenstonSingel 90aa6b6
Clean up and organize the repository's build scripts
FenstonSingel 5898535
Introduce a Gradle version catalog
FenstonSingel 94fce17
Introduce new infrastructure for builds as a Kotlin user project
FenstonSingel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -1,25 +1,20 @@ | ||||||||
/* | ||||||||
* Copyright 2019-2023 JetBrains s.r.o. and contributors. | ||||||||
* Use of this source code is governed by the Apache 2.0 License that can be found in the LICENSE.txt file. | ||||||||
*/ | ||||||||
import org.jetbrains.kotlin.gradle.tasks.KotlinCompilationTask | ||||||||
|
||||||||
plugins { | ||||||||
id("kotlin") | ||||||||
kotlin("jvm") | ||||||||
id("me.champeau.jmh") | ||||||||
} | ||||||||
|
||||||||
|
||||||||
val mainJavaToolchainVersion by ext(project.property("java.mainToolchainVersion")) | ||||||||
val modularJavaToolchainVersion by ext(project.property("java.modularToolchainVersion")) | ||||||||
val jmhVersion: String by project | ||||||||
|
||||||||
sourceSets { | ||||||||
dependencies { | ||||||||
implementation(project(":kotlinx-datetime")) | ||||||||
implementation("org.openjdk.jmh:jmh-core:1.35") | ||||||||
implementation("org.openjdk.jmh:jmh-core:$jmhVersion") | ||||||||
} | ||||||||
} | ||||||||
|
||||||||
// Publish benchmarks to the root for the easier 'java -jar benchmarks.jar` | ||||||||
// publish benchmarks to the repository root for easier `java -jar benchmarks.jar` | ||||||||
tasks.named<Jar>("jmhJar") { | ||||||||
archiveBaseName = "benchmarks" | ||||||||
archiveClassifier = null | ||||||||
|
@@ -28,6 +23,9 @@ tasks.named<Jar>("jmhJar") { | |||||||
destinationDirectory = file("$rootDir") | ||||||||
} | ||||||||
|
||||||||
repositories { | ||||||||
mavenCentral() | ||||||||
// compile all Kotlin code from the module during full-repository builds | ||||||||
tasks.named("assemble") { | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
tasks.withType<KotlinCompilationTask<*>>().forEach { compileKotlinTask -> | ||||||||
dependsOn(compileKotlinTask) | ||||||||
Comment on lines
+28
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
} | ||||||||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.