Skip to content

Commit 5dd6374

Browse files
replaced div with span in root components
1 parent e321a2b commit 5dd6374

File tree

5 files changed

+16
-14
lines changed

5 files changed

+16
-14
lines changed

src/containers/ReferencesBanner/index.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ import React, { ReactElement } from "react";
22
import { ReferencesConfig, touch } from "../../shared";
33
import "./index.scss";
44

5-
type Props = ReferencesConfig & { regexDetermineBeta: RegExp };
5+
interface Props extends ReferencesConfig {
6+
regexDetermineBeta: RegExp;
7+
}
68

79
export default function ReferencesBanner({
810
pages,

src/pages/Author/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ async function checkReferences() {
111111
}
112112

113113
const container = document.body.insertBefore(
114-
document.createElement("div"),
114+
document.createElement("span"),
115115
document.body.firstChild,
116116
);
117117

src/pages/Jira/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ function createWFButton() {
2424
throw new Error("buttonsContainer is undefined");
2525
}
2626

27-
const rootDiv = document.createElement("div");
27+
const rootDiv = document.createElement("span");
2828
rootDiv.classList.add("aui-buttons");
2929

3030
const butCreateWF = createElement(

src/pages/LivePerf/index.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -120,27 +120,27 @@ async function checkMothersite(from: FromTypes) {
120120
const message = `MOTHERSITE LINKS ON THIS PAGE - ${mothersiteLinks}`;
121121

122122
if (mothersiteLinks > 0 && from === "content") {
123-
const rootDiv = document.createElement("div");
124-
rootDiv.classList.add("alertBanner");
123+
const rootDiv = document.createElement("span");
124+
125+
const root = createRoot(
126+
document.body.insertBefore(rootDiv, document.body.firstChild),
127+
);
125128

126129
const alertBannerElm = createElement(
127130
"div",
128-
{},
131+
{ className: "alertBanner" },
129132
createElement("h2", {}, message),
130133
createElement(
131134
"button",
132135
{
133136
onClick() {
134-
document.querySelector(".alertBanner")?.remove();
137+
root.unmount();
135138
},
136139
},
137140
"X",
138141
),
139142
);
140143

141-
const root = createRoot(
142-
document.body.insertBefore(rootDiv, document.body.firstChild),
143-
);
144144
root.render(alertBannerElm);
145145
} else {
146146
Browser.runtime.sendMessage({
@@ -287,11 +287,11 @@ async function findShowroomCode() {
287287
data: showroomConfig.data,
288288
});
289289

290-
const div: HTMLElement = document.createElement("div");
290+
const rootElm: HTMLElement = document.createElement("span");
291291

292292
const showroom = await waitForElm("#acc-showroom");
293293

294-
const root = createRoot(showroom.appendChild(div));
294+
const root = createRoot(showroom.appendChild(rootElm));
295295
root.render(showroomCodes);
296296
}
297297

src/pages/WFPage/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ async function usefulLinks() {
112112
);
113113

114114
const root = createRoot(
115-
container.appendChild(document.createElement("div")),
115+
container.appendChild(document.createElement("span")),
116116
);
117117
root.render(wfFixedLinks);
118118
}
@@ -142,7 +142,7 @@ function openAllPagesButton() {
142142
);
143143

144144
const root = createRoot(
145-
buttonsContainer.appendChild(document.createElement("div")),
145+
buttonsContainer.appendChild(document.createElement("span")),
146146
);
147147
root.render(buttonOpenAllPages);
148148
}

0 commit comments

Comments
 (0)