[Core][Future] Add linear algebra defines #14108
Open
+98
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenzorrilla
requested review from
RiccardoRossi,
jcotela,
loumalouomega and
pooyan-dadvand
rubenzorrilla
added
Kratos Core
FastPR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds two headers to define the serial and MPI linear algebra types. The idea of these is two use the
structs inside as unique template arguments for all the new strategies environment.Besides simplifying quite a lot the implementation and reducing the template specialization complexity, these ensure that the linear algebra pairs (i.e., matrix and vector) are compatible. Also note that these also simplify the extension to other data types (e.g.,
floatvsdouble) or even to other array types.A subsequent PR will incorporate these (and other features) into the future strategies, schemes, builders and linear solvers.
EDIT: I placed them into
containersfolder without being sure if this is the best place. Feel free to suggest any other folder.