[GeoMechanicsApplication] Add intersection between compression cap yield surface and Coulomb yield surface#14292
Draft
mnabideltares wants to merge 17 commits intomasterfrom
Draft
[GeoMechanicsApplication] Add intersection between compression cap yield surface and Coulomb yield surface#14292mnabideltares wants to merge 17 commits intomasterfrom
mnabideltares wants to merge 17 commits intomasterfrom
Conversation
…ion-cap-with-coulomb' into geo/14136-intersection-cap-with-coulomb
…ion-cap-with-coulomb
Class `InterfaceCoulombWithTensionCutOff` explicitly checks whether this new flag is not set to True, since that is not supported.
Added a local helper function that creates an optional compression cap based on the given material properties.
…ion-cap-with-coulomb Also resolved some merge conflicts together with Mohamed.
avdg81
reviewed
Mar 16, 2026
Contributor
avdg81
left a comment
There was a problem hiding this comment.
Hi Mohamed,
Thank you very much for preparing the integration of the compression cap into the Coulomb model. Since there are still two failing unit tests, this PR probably needs a bit more work, but what you've made so far is a very nice starting point. 👍
I have several suggestions for you, all quite minor things. I also have several questions, which are probably the result of my lack of understanding. I would appreciate it very much if you could help me understand better how the compression cap works. Thanks.
applications/GeoMechanicsApplication/custom_constitutive/compression_cap_yield_surface.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_constitutive/compression_cap_yield_surface.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_constitutive/coulomb_with_tension_cut_off_impl.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_constitutive/coulomb_with_tension_cut_off_impl.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_constitutive/coulomb_with_tension_cut_off_impl.h
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
The cap yield surface and the Coulomb yield surface intersect. In order to determine the mapping zone, the intersection point of the cap and Coulomb yield surfaces must be identified.
This formulation is required in terms of the stress invariants 𝑝–𝑞, rather than the 𝜎–𝜏 representation. Therefore, the Coulomb yield surface must first be expressed in 𝑝–𝑞 space.
The procedure is as follows:
🆕 Changelog