Conversation
NickNick9
reviewed
Mar 17, 2026
Contributor
NickNick9
left a comment
NickNick9
left a comment
There was a problem hiding this comment.
Looks good.
Just for me to know, you did not applied the same for 3d, right?
| } | ||
|
|
||
| // checks if the node exists in the surrogate model part otherwise create it | ||
| auto ensure_surrogate_node = [&](IndexType node_id, int node_i, int node_j) { |
Contributor
There was a problem hiding this comment.
Can you create a Method of the class?
also ensure_surrogate_node is not enough self-explaining in my opinion
Contributor
Author
It should be applied to 3D for what concerns the elimination of the unused control points, but I didn't touch the 3D snake process. It should be easily extendable to 3D anyway |
NickNick9
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Avoid the creation of useless Nodes and control points of the background mesh
🆕 Changelog
-SnakeSbmProcess::CreateSurrogateBuondaryFromSnakeInner/Outer:
- Creates the surrogate nodes directly in the loop for the construction of the surrogate edges
- ensure_surrogate_node function to check if the nodes are already created in the modelPart
- Additional method ActivateNodesInElementsAndCleanRoot
- Remove all the Control Points (Nodes) which are not included in the elements created