Skip to content

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Sep 2, 2025

Description

  • Because we create the workspace directory from experiment --dest and system --dest, we must consider the case where the user provides absolute path for these. This PR makes a change where absolute paths and relative paths will result in the same workspace directory. The common path between the experiment, system, and workspace directories is only used once.
  • Example shown here WIP: Add Lanl CTS-2 system rocinante to system definitions #1006 (comment)

Adding/modifying core functionality, CI, or documentation:

  • Update lib/benchpark/cmd/setup.py

@michaelmckinsey1 michaelmckinsey1 self-assigned this Sep 2, 2025
@michaelmckinsey1 michaelmckinsey1 added the bug Something isn't working label Sep 2, 2025
@github-actions github-actions bot added the feature New feature or request label Sep 2, 2025
@michaelmckinsey1 michaelmckinsey1 changed the title [WIP] Fix Workspace Path Configuration in Setup Fix Workspace Path Configuration in Setup Sep 2, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.13%. Comparing base (0fd5941) to head (8c3a9df).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1007      +/-   ##
===========================================
+ Coverage    65.08%   65.13%   +0.04%     
===========================================
  Files           44       44              
  Lines         3148     3152       +4     
  Branches       237      237              
===========================================
+ Hits          2049     2053       +4     
  Misses        1092     1092              
  Partials         7        7              
Files with missing lines Coverage Δ
lib/benchpark/cmd/setup.py 93.51% <100.00%> (+0.24%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelmckinsey1 michaelmckinsey1 added the ready for review Ready for review label Sep 3, 2025
@pearce8 pearce8 requested a review from scheibelp September 3, 2025 19:07
@pearce8 pearce8 added this pull request to the merge queue Sep 4, 2025
Merged via the queue into develop with commit 2e556a3 Sep 4, 2025
42 checks passed
@pearce8 pearce8 deleted the fix-paths branch September 4, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants