Adding support for Commbench as a new experiment, also adding El Dorado as a system #1042
Conversation
github-actions
bot
added
experiment
repo/cray-mpich/package.py
Outdated
|
|
||
| if self.spec.satisfies("+gtl"): | ||
| gtl_lib_prefix = self.spec.extra_attributes["gtl_lib_path"] | ||
| gtl_lib_prefix = self.spec.extra_attributes["gtl_path"] + "/lib" |
There was a problem hiding this comment.
@nhanford Is this not standard? If it is different on our systems and SNL systems, how should we be handling this?
There was a problem hiding this comment.
So I have added logic to address this:
I have tested it on SNL systems, it should work for LLNL, but needs to be tested.
There was a problem hiding this comment.
This appears similar to https://github.com/LLNL/benchpark/blob/develop/systems/llnl-elcapitan/system.py, so I added some references about what needs to change with the merge of #953
(package recipe looks compatible, no notes there)
| selections["compilers"] += self.rocm_cce_compiler_cfg()["compilers"] | ||
|
|
||
| # Note: this is always included for some low-level dependencies | ||
| # that shouldn't build with %cce |
There was a problem hiding this comment.
I think this note is supposed to attach to gcc
| if self.spec.satisfies("compiler=cce") or self.spec.satisfies( | ||
| "compiler=rocmcc" | ||
| ): | ||
| selections["compilers"] += self.rocm_cce_compiler_cfg()["compilers"] |
There was a problem hiding this comment.
The specification for this changed: it looks like https://github.com/LLNL/benchpark/blob/develop/systems/llnl-elcapitan/system.py is a close match (uses all the same compilers). If you have questions about that, let me know.
|
|
||
| return selections | ||
|
|
||
| def compiler_weighting_cfg(self): |
There was a problem hiding this comment.
I think you can entirely replace this with the implementation of compiler_weighting_cfg from https://github.com/LLNL/benchpark/blob/develop/systems/llnl-elcapitan/system.py
| } | ||
| } | ||
|
|
||
| selections["packages"] |= self.compiler_weighting_cfg()["packages"] |
There was a problem hiding this comment.
When combining separate config dicts you'll now want to use merge_dicts (example in https://github.com/LLNL/benchpark/blob/develop/systems/llnl-elcapitan/system.py)
Adding El Dorado system (docs: Adding a System)
systems/snl-eldorado/system.pyfile - only if it is different from El Capitan software stacksystems/all_hardware_descriptions/hardware_name/hardware_description.yamlwhich will appear in the docs catalogueAdding Commbench benchmark (docs: Adding a Benchmark)
application.pyor inrepo/benchmark_name/application.pywill appear in the docs catalogue