-
Notifications
You must be signed in to change notification settings - Fork 39
Rewrite System Documentation #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks generally good - thanks! I have a couple questions and a couple suggestions (but nothing that should block this).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1062 +/- ##
===========================================
- Coverage 65.49% 65.43% -0.07%
===========================================
Files 44 44
Lines 3237 3240 +3
Branches 256 256
===========================================
Hits 2120 2120
- Misses 1110 1113 +3
Partials 7 7
🚀 New features to boost your workflow:
|
Description
benchpark system external
for spack1.0Adding/modifying a system (docs: Adding a System)
systems/aws-tutorial
Adding/modifying core functionality, CI, or documentation:
update-a-system-config.rst
to appendix inadd-a-system-config.rst