Skip to content

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Sep 17, 2025

Description

  • Rewrite system documentation, specific to spack1.0 changes
  • Fix benchpark system external for spack1.0
  • Improve instructions on package finding process -> moved docs from own page to appendix in new system docs.
  • Should address Update docs for Spack 1.0 #1049

Adding/modifying a system (docs: Adding a System)

  • Update systems/aws-tutorial

Adding/modifying core functionality, CI, or documentation:

  • move content from update-a-system-config.rst to appendix in add-a-system-config.rst

@michaelmckinsey1 michaelmckinsey1 self-assigned this Sep 17, 2025
@michaelmckinsey1 michaelmckinsey1 added the WIP A work-in-progress not yet ready to commit label Sep 17, 2025
@github-actions github-actions bot added the docs Improvements or additions to documentation label Sep 17, 2025
@github-actions github-actions bot added the system New or modified system config label Sep 22, 2025
@github-actions github-actions bot added the feature New feature or request label Sep 22, 2025
@michaelmckinsey1 michaelmckinsey1 changed the title [WIP] Rewrite System Documentation Rewrite System Documentation Sep 22, 2025
@michaelmckinsey1 michaelmckinsey1 marked this pull request as ready for review September 22, 2025 22:41
@michaelmckinsey1 michaelmckinsey1 added ready for review Ready for review and removed WIP A work-in-progress not yet ready to commit labels Sep 22, 2025
Copy link
Collaborator

@scheibelp scheibelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally good - thanks! I have a couple questions and a couple suggestions (but nothing that should block this).

@pearce8 pearce8 added the changes requested Changes requested label Sep 23, 2025
@michaelmckinsey1 michaelmckinsey1 linked an issue Sep 23, 2025 that may be closed by this pull request
2 tasks
@michaelmckinsey1 michaelmckinsey1 added ready for review Ready for review and removed changes requested Changes requested labels Sep 23, 2025
scheibelp
scheibelp previously approved these changes Sep 24, 2025
@slabasan slabasan enabled auto-merge September 24, 2025 05:10
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.43%. Comparing base (9ec3377) to head (cc4f8fd).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
lib/benchpark/cmd/system.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1062      +/-   ##
===========================================
- Coverage    65.49%   65.43%   -0.07%     
===========================================
  Files           44       44              
  Lines         3237     3240       +3     
  Branches       256      256              
===========================================
  Hits          2120     2120              
- Misses        1110     1113       +3     
  Partials         7        7              
Files with missing lines Coverage Δ
lib/benchpark/cmd/system.py 53.84% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slabasan slabasan added this pull request to the merge queue Sep 24, 2025
@pearce8 pearce8 removed this pull request from the merge queue due to a manual request Sep 24, 2025
@pearce8 pearce8 merged commit edb436d into develop Sep 24, 2025
42 checks passed
@pearce8 pearce8 deleted the new-system-docs branch September 24, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation feature New feature or request ready for review Ready for review system New or modified system config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs for Spack 1.0
5 participants