-
Notifications
You must be signed in to change notification settings - Fork 39
[WIP] Automatically Enumerate Dryruns using CI Matrix #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c7a0eab
to
c365d35
Compare
Example JSON file created by the new script. For each variant, a separate job is started for each |
8239062
to
ff60eb9
Compare
Being addressed in #714 |
|
77ac5fe
to
ab20635
Compare
ab20635
to
99776e3
Compare
Depends on #714 to fix unit tests |
@michaelmckinsey1 please take a look at #717 and let me know how you could use it in this PR. |
@pearce8 with parent classes we could update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelmckinsey1 Please resolve conflicts, and lets talk about what needs to be done in this PR vs. later.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #701 +/- ##
===========================================
+ Coverage 40.30% 41.40% +1.09%
===========================================
Files 15 22 +7
Lines 1119 1512 +393
Branches 152 214 +62
===========================================
+ Hits 451 626 +175
- Misses 632 841 +209
- Partials 36 45 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Superseded by #904 |
Description
Downsides:
checks
tab for better visualization of jobs).llnl-cluster cluster=ruby compiler=not-default
would require its own jobThe ability to run newly added
experiment.py
's in CI without changes to any CI files (.github
), usingbenchpark list experiments
(which will pick up any new experiments added to benchpark).Removes 975 lines of CI from
.github/workflows/run.yml
that we no longer need to maintain.CI completes much faster, as checks run in parallel instead of sequentially.
This PR has caught errors with experiments that were not caught in develop CI
step still, and require an update to the python script. Otherwise, the user could add one-off CI the same way as before.
This only tests 4 systems. Perhaps the others could each get a manual unit test?
Depends on Starting provides, requires directives #717.
Update benchpark list systems to say which ones provide ProgrammingModel (cuda, rocm, openmp) Update
benchpark list
to query programming model #903Update benchpark list experiments to say which ones require ProgrammingModel
Generate experiment lists semi-dynamically (for now, only want Livermore systems and benchmarks)
Can we run multiple jobs in the same allocation?
Related to Extend docs to specify checklist of what's needed for experiment #424
Update docs
Update
.github/workflows
and.gitlab/ci
unit tests (if needed)