[WIP] Use Enums to Enforce Syntax #945
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmckinsey1
requested changes
Aug 4, 2025
There was a problem hiding this comment.
From @scheibelp :
- Import respective enums from class (cuda enum should come from cuda.py)
- make variable names more succinct where possible
| return "single_node" if self.spec.satisfies("+single_node") else "" | ||
|
|
||
|
|
||
| class AffinityVariantValues(str, Enum): |
There was a problem hiding this comment.
I think this could be AffinityEnum and we could make a base enum class for the tuple_values methods etc. that are shared across enums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently checks such as
self.spec.satisfies("affinity=none"):will not error if there is a spelling/syntax mistake within the argument, e.g.self.spec.satisfies("affinity=non"):(missing "e"). This will of course not be a syntax error, and the expected usage from the command line will not satisfy this condition. The changes in this PR uses Enums to avoid these programming mistakes, which are potentially difficult to debug.Adding/modifying core functionality, CI, or documentation:
lib/benchpark/experiment.py