Skip to content

Conversation

tdrwenski
Copy link
Collaborator

This PR re-enables compiler warnings and fixes them. The types of fixes are unused parameters/ variables, unsigned/signed comparisons, a deprecated Petsc function, and uninitialized variables. It may be easier to review by looking through the individual commits-- I tried to keep similar fixes all together.

@tdrwenski tdrwenski requested a review from steffi7574 March 21, 2025 19:54
Copy link
Member

@steffi7574 steffi7574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks!
Please comment out rather than remove the few unused lines in src/util.cpp, as commented, otherwise all good to go.

@tdrwenski tdrwenski merged commit f5154b4 into main Mar 21, 2025
6 checks passed
@tdrwenski tdrwenski deleted the fix-warnings branch March 21, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants