CI and build fixes #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
force-pushed
the
ci-build-fixes
branch
3 times, most recently
from
ce74d97 to
c1cdec9
Compare
tdrwenski
force-pushed
the
ci-build-fixes
branch
from
c1cdec9 to
175e13e
Compare
tdrwenski
commented
Apr 4, 2025
| @@ -25,9 +25,6 @@ find_package(PkgConfig REQUIRED) | |||
| pkg_search_module(PETSC REQUIRED IMPORTED_TARGET PETSc) | |||
| target_link_libraries(quandary_lib PUBLIC PkgConfig::PETSC) | |||
|
|
|||
| # Other libraries | |||
| target_link_libraries(quandary_lib PUBLIC m blas lapack) | |||
There was a problem hiding this comment.
@steffi7574 This should fix your issue
steffi7574
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some adjustments to the CI and build:
flux;runon certain machines so a bit of a hack to get that to work correctly)Note: we still depend on my branch for radiuss-spack-configs and spack after this PR, will have to wait to update that. We need to wait til latest spack changes (to get the CMakeCache mpi exec fix), which have some breaking changes, are incorporated in radiuss-spack-configs.