Write and Read only nonzero Hamiltonian elements #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
reviewed
Jun 23, 2025
Co-authored-by: Tara Drwenski <tdrwenski@users.noreply.github.com>
…to read-sparse-hamiltonian
|
Looks good to me! Possibly the test expected results or input matrix needs to be updated though as it looks like the results are slightly different than expected, could it be related to the switching the order of matrix A and B? |
Previously, the hamiltonian-reader regression test used a random initialization of the control parameters, which, apparently, is different when running on different machines. This changes the configuration for this test to use constant control parameters, to produce the same output on all machines.
tdrwenski
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.