[GPU] Interpolators #400

ldowen · 2025-07-28T22:58:07Z

Summary

This PR is a feature for using interpolator classes on the device.
It does the following:
- Refactors interpolators to have value/view/base classes.
- Adds a SPHERAL_GPU_ENABLED macro for when GPUs are enabled.

ToDo :

Annotate RELEASE_NOTES.md with notable changes.
Create LLNLSpheral PR pointing at this branch. (PR#)
LLNLSpheral PR has passed all tests.

…this will break the python interface and anything that uses QI so a WIP, created a QI test for GPUs, created the SPHERAL_GPU_ENABLED macro

…its from base and can make a view instance, and create a QIView class that also inherits from base

src/Utilities/QuadraticInterpolator.cc

…ded tests

…or QI and CHI and changed the python test where necessary

…lasses, made a std::vector in the QI and CHI value classes to hold the actual data instead of a MA

… CHI classes

ldowen · 2025-08-07T17:28:55Z

NOTE: Change convention Base to be View.

… and camp, changed cmake variables to only use external chai

…arget script, updated leos version to 8.5.2, fixed leos spack package recipe, update spheral spack recipe, added link library option to SpheralHandleTPL.cmake

This reverts commit f5b71f2.

This reverts commit 63c1770.

This reverts commit afd2f58.

This reverts commit a21597d.

… and libraries back, fixed prev bug added to spheral spack recipe

… to make some TPLs debug when build_type=Debug is added to the spack spec

…ke logic

…sy way

… segfault occurs on exit

…erted leos version back to 8.4.2, added memory type and exec space things to leos code for when we do end up using it, reverted back to using shared libraries for C++ libraries

…scii files

…essary

…when +leos

…oken

… when this is revisited

…g MA, changed view call to be a static_cast

ldowen added 2 commits July 25, 2025 15:06

Created the QIHandler class for handling QuadraticInterpolator data, …

a58f99c

…this will break the python interface and anything that uses QI so a WIP, created a QI test for GPUs, created the SPHERAL_GPU_ENABLED macro

Created a QI base class, make the QI class the value class that inher…

86b7464

…its from base and can make a view instance, and create a QIView class that also inherits from base

ldowen requested review from jmikeowen and mdavis36 July 28, 2025 22:58

ldowen self-assigned this Jul 28, 2025

ldowen marked this pull request as draft July 28, 2025 22:58

mdavis36 reviewed Jul 28, 2025

View reviewed changes

src/Utilities/QuadraticInterpolator.cc Outdated Show resolved Hide resolved

mdavis36 reviewed Jul 28, 2025

View reviewed changes

src/Utilities/QuadraticInterpolator.cc Outdated Show resolved Hide resolved

ldowen added 7 commits July 28, 2025 16:50

Switched QI to use managed arrays instead of calling Umpire directly

23d8ba2

Removed the QIView class, GPUified the CubicHermitInterpolator and ad…

b6aa325

…ded tests

Added default constructors for QI and CHI, added the index operator f…

8ac532c

…or QI and CHI and changed the python test where necessary

Added move operation to QIBase and CHIBase

9f7ef88

Added copy and assignment constructors and tests for the QI and CHI c…

440e72b

…lasses, made a std::vector in the QI and CHI value classes to hold the actual data instead of a MA

Add explicit calls to base copy and assignment constructors in QI and…

653bf65

… CHI classes

Updated RELEASE_NOTES to test new mirror

891ef90

ldowen added 2 commits August 14, 2025 16:49

Merge branch 'develop' into feature/gpu/interpolators

c5c9be6

Changed QIBase and CHIBase to QIView and CHIView

b427ef6

ldowen closed this Aug 18, 2025

ldowen reopened this Aug 18, 2025

ldowen added 10 commits August 18, 2025 13:08

Merge branch 'develop' into feature/gpu/interpolators

3d3436e

Merge branch 'develop' into feature/gpu/interpolators

fc918f8

Removed unused line in QI

b7191e3

Removed chai submodule, added package recipes for chai, raja, umpire,…

7420d98

… and camp, changed cmake variables to only use external chai

Chagned getPointer to data

f630226

Update release notes

0f30958

Merge branch 'develop' into update/remove_chai_submodule

0a88b0e

Changed ENABLE_HIP to SPHERAL_ENABLE_HIP and added it to the export t…

e3d703b

…arget script, updated leos version to 8.5.2, fixed leos spack package recipe, update spheral spack recipe, added link library option to SpheralHandleTPL.cmake

Removed umpire variant logic

a21597d

Fix spack package typo

afd2f58

ldowen added 30 commits September 5, 2025 09:48

Revert "Change back to using ENABLE_HIP, let that be a different PR"

b6c136f

This reverts commit f5b71f2.

Revert "Turn off mpi for axom when ~mpi"

66c90f4

This reverts commit 63c1770.

Revert "Fix spack package typo"

21d150e

This reverts commit afd2f58.

Revert "Removed umpire variant logic"

7797465

This reverts commit a21597d.

Reverted SPHERAL_ENABLE_HIP back to just ENABLE_HIP, added leos flags…

ff6f203

… and libraries back, fixed prev bug added to spheral spack recipe

Forgot about typo in spack package

295ff7e

libleos_C.a does not exist for some reason

25a8736

Turn xml on for leos

dca07de

Explicitly turn off xml for leos

7b711b5

Do not use +xml variant in spheral

0eeca88

Switched to using find_package on hdf5 and LIP libraries, added logic…

84fd39a

… to make some TPLs debug when build_type=Debug is added to the spack spec

Try turning yaml off for leos and changing name of LIP package in cma…

5ae2642

…ke logic

Change lip to LIP

3863907

LIP is incorrectly exported so reverting back to importing it the mes…

b771c6e

…sy way

Fix hdf5 target names

2edf1ab

Add correct hdf5 targets to lists

f082082

Remove duplicated hdf5_DIR in fp_dirs list

5ecc1ac

Build static cxx libraries if rocm is turned on, otherwise mysterious…

d6ebe4f

… segfault occurs on exit

Changed umpire and raja versions based on feedback from Collette, rev…

7ceae95

…erted leos version back to 8.4.2, added memory type and exec space things to leos code for when we do end up using it, reverted back to using shared libraries for C++ libraries

Remove printf statement left in LEOS_bundle.cc

dbfe845

One other addition to the release notes

2b9243e

Bring yaml back to leos because it is apparently needed for reading a…

8ef5ced

…scii files

Make preferred leos package the older one for now

08696b5

Put link flags directly in blt call

8b77867

Add TPL dependencies and have leos get hip and cuda variants when nec…

0c5cb28

…essary

Change leos version back to 8.5.0 and ensure it is only a dependency …

444e36b

…when +leos

It seems leos 8.5.2 is more stable than 8.5.0 even if something is br…

009dc72

…oken

Reverting back to leos 8.4.2 without rocm versions but added note for…

63ffbbd

… when this is revisited

Merge with update/remove_chai_submodule

1ab74df

Fixed copy and assignment constructors for QI and CHI to avoid copyin…

a0799a0

…g MA, changed view call to be a static_cast

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[GPU] Interpolators #400

[GPU] Interpolators #400

Uh oh!

ldowen commented Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

ldowen commented Aug 7, 2025

Uh oh!

Uh oh!

[GPU] Interpolators #400

Are you sure you want to change the base?

[GPU] Interpolators #400

Uh oh!

Conversation

ldowen commented Jul 28, 2025

Summary

ToDo :

Uh oh!

Uh oh!

Uh oh!

ldowen commented Aug 7, 2025

Uh oh!

Uh oh!