Skip to content

Remove CHAI submodule #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Sep 24, 2025
Merged

Remove CHAI submodule #408

merged 51 commits into from
Sep 24, 2025

Conversation

ldowen
Copy link
Collaborator

@ldowen ldowen commented Aug 27, 2025 •
edited
Loading

Summary

  • This PR is an update
  • It does the following:
    • Removes the CHAI submodule
    • Adds Spack recipes for CHAI, RAJA, Umpire, and Camp
    • Adds CHAI as a Spack dependency for Spheral

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#168)
  • LLNLSpheral PR has passed all tests.

@ldowen
Removed chai submodule, added package recipes for chai, raja, umpire,…
7420d98 
… and camp, changed cmake variables to only use external chai
@ldowen ldowen requested a review from jmikeowen August 27, 2025 22:41
@ldowen ldowen self-assigned this Aug 27, 2025
jmikeowen
jmikeowen previously approved these changes Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once all the tests pass looks good

ldowen added 24 commits August 28, 2025 09:46
@ldowen
Update release notes
0f30958
@ldowen
Merge branch 'develop' into update/remove_chai_submodule
0a88b0e
@ldowen
Changed ENABLE_HIP to SPHERAL_ENABLE_HIP and added it to the export t…
e3d703b 
…arget script, updated leos version to 8.5.2, fixed leos spack package recipe, update spheral spack recipe, added link library option to SpheralHandleTPL.cmake
@ldowen
Removed umpire variant logic
a21597d
@ldowen
Fix spack package typo
afd2f58
@ldowen
Turn off mpi for axom when ~mpi
63c1770
@ldowen
Change back to using ENABLE_HIP, let that be a different PR
f5b71f2
@ldowen
Removed non-mpi CI tests
ed7355c
@ldowen
Removed redundant axom variant added a few commits ago, added spheral…
a5d599d 
… openmp define though it is unused
@ldowen
Revert "Removed redundant axom variant added a few commits ago, added…
68c45ca 
… spheral openmp define though it is unused"

This reverts commit a5d599d.
@ldowen
Revert "Removed non-mpi CI tests"
918a2ad 
This reverts commit ed7355c.
@ldowen
Revert "Change back to using ENABLE_HIP, let that be a different PR"
b6c136f 
This reverts commit f5b71f2.
@ldowen
Revert "Turn off mpi for axom when ~mpi"
66c90f4 
This reverts commit 63c1770.
@ldowen
Revert "Fix spack package typo"
21d150e 
This reverts commit afd2f58.
@ldowen
Revert "Removed umpire variant logic"
7797465 
This reverts commit a21597d.
@ldowen
Reverted SPHERAL_ENABLE_HIP back to just ENABLE_HIP, added leos flags…
ff6f203 
… and libraries back, fixed prev bug added to spheral spack recipe
@ldowen
Forgot about typo in spack package
295ff7e
@ldowen
libleos_C.a does not exist for some reason
25a8736
@ldowen
Turn xml on for leos
dca07de
@ldowen
Explicitly turn off xml for leos
7b711b5
@ldowen
Do not use +xml variant in spheral
0eeca88
@ldowen
Switched to using find_package on hdf5 and LIP libraries, added logic…
84fd39a 
… to make some TPLs debug when build_type=Debug is added to the spack spec
@ldowen
Try turning yaml off for leos and changing name of LIP package in cma…
5ae2642 
…ke logic
@ldowen
Change lip to LIP
3863907
ldowen added 25 commits September 8, 2025 14:18
@ldowen
LIP is incorrectly exported so reverting back to importing it the mes…
b771c6e 
…sy way
@ldowen
Fix hdf5 target names
2edf1ab
@ldowen
Add correct hdf5 targets to lists
f082082
@ldowen
Remove duplicated hdf5_DIR in fp_dirs list
5ecc1ac
@ldowen
Build static cxx libraries if rocm is turned on, otherwise mysterious…
d6ebe4f 
… segfault occurs on exit
@ldowen
Changed umpire and raja versions based on feedback from Collette, rev…
7ceae95 
…erted leos version back to 8.4.2, added memory type and exec space things to leos code for when we do end up using it, reverted back to using shared libraries for C++ libraries
@ldowen
Remove printf statement left in LEOS_bundle.cc
dbfe845
@ldowen
One other addition to the release notes
2b9243e
@ldowen
Bring yaml back to leos because it is apparently needed for reading a…
8ef5ced 
…scii files
@ldowen
Make preferred leos package the older one for now
08696b5
@ldowen
Put link flags directly in blt call
8b77867
@ldowen
Add TPL dependencies and have leos get hip and cuda variants when nec…
0c5cb28 
…essary
@ldowen
Change leos version back to 8.5.0 and ensure it is only a dependency …
444e36b 
…when +leos
@ldowen
It seems leos 8.5.2 is more stable than 8.5.0 even if something is br…
009dc72 
…oken
@ldowen
Reverting back to leos 8.4.2 without rocm versions but added note for…
63ffbbd 
… when this is revisited
@ldowen
Set ENABLE_SHARED to false, added openmp variants for umpire and chai…
78db850 
…, fixed finding leos when it is built with debug enabled
@ldowen
Made rocm package prefixes consistent and using the correct cray-mpic…
299571f 
…h version
@ldowen
Only get the file name for the leos yaml lib, not the whole path
60b923b
@ldowen
Do not add openmp variant to chai or umpire as it causes axom build t…
81b8f26 
…o fail for some reason
@ldowen
Cray-mpich 9.0.1 has an undefined symbol that causes tests to fail, r…
a8d1485 
…everting back to 8.1.31 for now
@ldowen
More release note updates
5a7506e
@ldowen
Forgot to make ~shared the default on spheral spack recipe
5114902
@ldowen
Changed ENABLED_SHARED back to the default since the python interface…
77fb7de 
… is broken with static libraries, added error messages in case someone tries building with a broken configuration
@ldowen
Include SpheralInstallPythonFiles in SetupSpheral.cmake, but not sure…
afa3191 
… why this was not an issue before
@ldowen
Added enable_shared() SpheralConfig, guard ldopenflags call in Sphera…
36b701b 
…l.py if C++ libraries are built statically
@ldowen ldowen merged commit 21e14ec into develop Sep 24, 2025
2 checks passed
@ldowen ldowen deleted the update/remove_chai_submodule branch September 24, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees

@ldowen ldowen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldowen @jmikeowen