Apply suggestions from code review

drreynolds · Steven-Roberts · web-flow · commit af67f188ef77 · 2024-08-29T12:06:07.000-05:00
Co-authored-by: Steven Roberts &lt;roberts115@llnl.gov&gt;
diff --git a/doc/shared/RecentChanges.rst b/doc/shared/RecentChanges.rst
@@ -15,7 +15,7 @@ Fixed the loading of ARKStep's default first order explicit method.
 Fixed a CMake bug regarding usage of missing "print_warning" macro
 that was only triggered when the deprecated ``CUDA_ARCH`` option was used.
 
-Fixed a memory leak that could occur if if ARKodeSetDefaults is called
+Fixed a memory leak that could occur if :c:func:`ARKodeSetDefaults` is called
 repeatedly.
 
 **Deprecation Notices**
diff --git a/src/arkode/arkode_arkstep_io.c b/src/arkode/arkode_arkstep_io.c
@@ -724,7 +724,6 @@ int arkStep_SetDefaults(ARKodeMem ark_mem)
       return (ARK_MEM_FAIL);
     }
   }
-  ark_mem->hadapt_mem->hcontroller = NULL;
   ark_mem->hadapt_mem->hcontroller = SUNAdaptController_PID(ark_mem->sunctx);
   if (ark_mem->hadapt_mem->hcontroller == NULL)
   {

Original file line number	Diff line number	Diff line change
`@@ -724,7 +724,6 @@ int arkStep_SetDefaults(ARKodeMem ark_mem)`
`724`	`724`	`return (ARK_MEM_FAIL);`
`725`	`725`	`}`
`726`	`726`	`}`
`727`		`- ark_mem->hadapt_mem->hcontroller = NULL;`
`728`	`727`	`ark_mem->hadapt_mem->hcontroller = SUNAdaptController_PID(ark_mem->sunctx);`
`729`	`728`	`if (ark_mem->hadapt_mem->hcontroller == NULL)`
`730`	`729`	`{`