Skip to content

Conversation

balos1
Copy link
Member

@balos1 balos1 commented Jun 30, 2025

No description provided.

@balos1 balos1 added the ci label Jun 30, 2025
@gardner48 gardner48 changed the title lock down gitlab ci to ginkgo 1.9.0 CI: lock down gitlab ci to ginkgo 1.9.0 Jun 30, 2025
@gardner48 gardner48 added this to the SUNDIALS Next milestone Jun 30, 2025
gardner48
gardner48 previously approved these changes Jun 30, 2025
@balos1
Copy link
Member Author

balos1 commented Jun 30, 2025

FS permissions should be fixed too

@gardner48 gardner48 dismissed their stale review July 21, 2025 21:08

The merge-base changed after approval.

@gardner48 gardner48 force-pushed the develop branch 2 times, most recently from 894262a to 7df148d Compare July 21, 2025 22:29
@gardner48 gardner48 removed this from the SUNDIALS Next milestone Jul 22, 2025
@gardner48 gardner48 force-pushed the maintenance/fix-ginkgo-version branch from c69daaf to e243f57 Compare July 22, 2025 16:24
@gardner48 gardner48 added this to the SUNDIALS After Next milestone Jul 22, 2025
@balos1
Copy link
Member Author

balos1 commented Aug 26, 2025

@gardner48 I believe this can be merged now. The CI output looks good. Ginkgo is not reinstalled, it it pulled from the binary cache.

@gardner48 gardner48 merged commit 2f37185 into develop Aug 26, 2025
49 checks passed
@gardner48 gardner48 deleted the maintenance/fix-ginkgo-version branch August 26, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants