Add message about switching to default SPRK order #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steven-Roberts
requested review from
balos1,
gardner48,
cswoodward and
drreynolds
as code owners
balos1
previously approved these changes
Sep 4, 2024
balos1
reviewed
Sep 4, 2024
There was a problem hiding this comment.
ARK_WARNING would probably be better, because then the output would go through the warning handler instead of the error handler. See https://github.com/LLNL/sundials/blob/main/src/arkode/arkode.c#L3555. However, we want the behavior to be consistent across all of the steppers and they seem to use ARK_ILL_INPUT.
|
I'll go ahead and make them all warnings across ARKODE in this PR then. |
gardner48
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes SPRKStep's handling of an invalid order consistent with the rest of ARKODE (following #439). Currently an invalid order is an error, but it doesn't leave the integrator in an invalid state or prevent the integration from proceeding. For this reason I wonder if
ARK_WARNINGwould be more appropriate for theerror_code.