Skip to content
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
120 commits
Select commit Hold shift + click to select a range
2e4a100
Initial implementation of command-line control over ARKODE inputs
drreynolds Feb 6, 2025
4ee0ced
Added const qualifier
drreynolds Feb 6, 2025
7fe32c7
Apply suggestions from code review
drreynolds Feb 25, 2025
567d885
Additional updates based on PR feedback
drreynolds Feb 25, 2025
834be77
Added const for char* argv[] to subsidiary functions
drreynolds Feb 25, 2025
843b240
Converted separate arrays to arrays of structs
drreynolds Feb 26, 2025
81da918
Removed const decorator from argv inputs to ARKodeSetFromCommandLine,…
drreynolds Feb 26, 2025
ccb3a0d
Updated swig interfaces
drreynolds Feb 26, 2025
3ff1574
Updated handling of errors when setting command-line arguments
drreynolds Feb 26, 2025
5697de0
Updated ARKodeSetFromCommandLine to include an input 'arkid' that sho…
drreynolds Feb 26, 2025
229c013
Updated swig interfaces
drreynolds Feb 26, 2025
6d55e2d
Updated comment
drreynolds Feb 26, 2025
f88f66b
Updated formatting
drreynolds Feb 26, 2025
9a552b9
Updated type for 'offset' to size_t to avoid conversion warnings/errors
drreynolds Feb 26, 2025
62fecac
Apply suggestions from code review to automatically determine the num…
drreynolds Feb 27, 2025
3eece32
Moved command-line input control to a separate file
drreynolds Feb 27, 2025
17000e9
Updated handling of arkid input according to Steven's suggestion
drreynolds Feb 27, 2025
cbdaf2d
Updated includes now that cli interface is separated into a new file
drreynolds Feb 27, 2025
44abb69
Added support for a new writeparameters command-line option, that wil…
drreynolds Feb 27, 2025
d65c219
Added function pointer for stepper-specific setfromcommandline functi…
drreynolds Feb 27, 2025
60e3287
Added placeholder for ARKStep command-line processing (needs to be fi…
drreynolds Feb 27, 2025
20e3232
Moved typedefs and general CLI utility routines up to SUNDIALS level,…
drreynolds Mar 2, 2025
00991b5
Added command-line support to ARKStep
drreynolds Mar 2, 2025
a451341
Added command-line support to ERKStep
drreynolds Mar 2, 2025
4880960
Added command-line support to SPRKStep and LSRKStep
drreynolds Mar 2, 2025
961ed95
Added command-line support to MRIStep
drreynolds Mar 3, 2025
dd29861
Added command-line support to ark_kpr_mri.c for manual testing (passes)
drreynolds Mar 3, 2025
c175f56
Formatting
drreynolds Mar 3, 2025
b1fd734
Update src/arkode/arkode_cli.c
drreynolds Mar 12, 2025
d24a61a
Moved sundials_cli.h to src/sundials
drreynolds Mar 12, 2025
a0e5a17
Added ARKODE command-line control for linear solver set routines
drreynolds Mar 12, 2025
459c58b
Added command-line control for CVODE
drreynolds Mar 12, 2025
d35479e
Added command-line control for CVODE
drreynolds Mar 12, 2025
3a9a4ff
Added command-line control to CVODES
drreynolds Mar 13, 2025
0c525e0
Added command-line control to IDA
drreynolds Mar 13, 2025
8cc31f8
Added command-line control to IDAS
drreynolds Mar 13, 2025
d67bd22
Added command-line control to KINSOL
drreynolds Mar 13, 2025
7db9133
Regenerated SWIG interfaces
drreynolds Mar 13, 2025
f747539
Formatting
drreynolds Mar 13, 2025
1e6f96f
Applied spelling 'patch', that forced me to rename the long-int varia…
drreynolds Mar 13, 2025
cefc028
Added command-line control over SUNAdaptControllers
drreynolds Mar 14, 2025
b276550
Updated Swig interfaces
drreynolds Mar 14, 2025
f0cc756
Added command-line control over SUNLinearSolvers
drreynolds Mar 16, 2025
1aced24
Fixed unused variable warning/error
drreynolds Mar 16, 2025
29dfdce
Fixed unused variable warning/error
drreynolds Mar 16, 2025
7fc20d1
formatting
drreynolds Mar 16, 2025
63466df
Minor updates to hopeflly fix build on Windows/MSVC
drreynolds Mar 16, 2025
16dfb96
Fixed missing include
drreynolds Mar 16, 2025
e35b1bf
Fixed missing include
drreynolds Mar 16, 2025
575a86f
formatting
drreynolds Mar 16, 2025
4ab74ca
Added missing SUNDIALS_EXPORT
drreynolds Mar 16, 2025
e4c57e0
Removed explicit cast that I introduced when trying to resolve Window…
drreynolds Mar 16, 2025
bb35002
formatting
drreynolds Mar 16, 2025
ef344c6
Added documentation for command-line control
drreynolds Mar 23, 2025
dc04506
Merged upstream changes
drreynolds Mar 25, 2025
5793e29
Formatting
drreynolds Mar 25, 2025
e8dad98
Fixed quotation marks
drreynolds Mar 25, 2025
af73d8e
Documented command-line control over SUNAdaptController and SUNLinear…
drreynolds Mar 26, 2025
3b41971
Removed SetFromCommandLine functions from linear solver and adaptivit…
drreynolds Apr 2, 2025
4528bdf
Updated commands to remove SetFromCommandLine routines from some SWIG…
drreynolds Apr 2, 2025
1882fec
Fixed missing {
drreynolds Apr 2, 2025
5596787
Formatting
drreynolds Apr 2, 2025
431a12b
Merge ../develop into feature/commandline
drreynolds Apr 2, 2025
09e2303
Applied all minor suggestions from code review. Will start on larger …
drreynolds May 22, 2025
a1f74ce
Converted other integrator cli files to SUNErrCode
drreynolds May 22, 2025
87c67ae
Converted 'static struct sunKey*' to 'static const struct sunKey*'
drreynolds May 22, 2025
4f1f51c
Converted *SetFromCommandLine routines to treat NULL-valued IDs as th…
drreynolds May 22, 2025
2728204
Removed 'const' from offset argument to ARKODE stepper-specific SetFr…
drreynolds May 22, 2025
c82a954
Additional fixes to address PR reviews
drreynolds May 22, 2025
dcb9451
Merged in changes from develop
drreynolds Jun 11, 2025
73abfba
Applied formatting patch
drreynolds Jun 11, 2025
297a31e
Fixed merge issue
drreynolds Jun 11, 2025
e2fbeb8
Added utility routines to loop through lists of arguments to call set…
drreynolds Jun 30, 2025
a1b96ef
Added more CI tests for command-line arguments
drreynolds Jun 30, 2025
5904780
Added documentation for command-line processing to the developer guide
drreynolds Jul 5, 2025
946ce32
Removed unused CLI utility routines
drreynolds Jul 5, 2025
b4f8c88
Added additional notes to the SUNAdaptController documentation
drreynolds Jul 5, 2025
8174b55
Added note on command-line options to the developer guide checklist
drreynolds Jul 5, 2025
bbf2cc2
Merge branch 'develop' into feature/commandline
gardner48 Jul 5, 2025
ddf872f
fix spelling
gardner48 Jul 5, 2025
49232f7
apply formatting
gardner48 Jul 5, 2025
97b61b6
include errors impl header, remove unused variables
gardner48 Jul 5, 2025
a0a97d1
add missing output file
gardner48 Jul 6, 2025
ad8c547
add new output files
gardner48 Jul 6, 2025
87d9f17
update answers submodule
gardner48 Jul 6, 2025
c31a78c
Merge branch 'develop' into feature/commandline
gardner48 Jul 8, 2025
26e8863
Merge branch 'develop' into feature/commandline
gardner48 Jul 10, 2025
b0ba553
update answers submodule
gardner48 Jul 10, 2025
ce0b020
update answers submodule
gardner48 Jul 10, 2025
534c4d9
apply formatting
gardner48 Jul 10, 2025
619d5e2
update answers submodule
gardner48 Jul 10, 2025
4ff4273
Applied some minor recommendations
drreynolds Jul 15, 2025
e72d741
Applied some minor recommendations to the ARKODE docs, and made some …
drreynolds Jul 15, 2025
7b11a0c
Applied multiple minor recommendations from PR review
drreynolds Jul 15, 2025
57d88e7
Converted *SetFromCommandLine routines into *SetOptions routines (as …
drreynolds Jul 16, 2025
e2e8cfc
formatting
drreynolds Jul 16, 2025
277e3ff
swig
drreynolds Jul 16, 2025
86798ab
Fixed swig ignores for new function names
drreynolds Jul 16, 2025
c4080f9
Swig
drreynolds Jul 16, 2025
522a960
Fixed missing 'static'
drreynolds Jul 17, 2025
a8241f2
formatting
drreynolds Jul 17, 2025
f733ef1
Moved logic to set command-line prefixes outside of argument loop
drreynolds Jul 17, 2025
b1f3438
formatting
drreynolds Jul 17, 2025
4cebebc
removed unused variables
drreynolds Jul 17, 2025
827e9c4
removed unused variables
drreynolds Jul 18, 2025
ec435bb
Updated handling of command-line prefixes
drreynolds Jul 18, 2025
887967e
formatting
drreynolds Jul 18, 2025
e573a0e
Updated documentation to clarify the role of the '.' separator betwee…
drreynolds Jul 18, 2025
2e3660b
Updated ark_analytic.c example to output solver parameters _after_ co…
drreynolds Jul 18, 2025
78c7040
Updated idaAnalytic.c example to omit output of tolerances
drreynolds Jul 18, 2025
b5c1259
Updated idasAnalytic_mels to output the initial time step size taken
drreynolds Jul 18, 2025
e5f9b48
Removed command-line control over deprecated SPRKStepUseCompensatedSu…
drreynolds Jul 18, 2025
35b1f5d
Added command-line control over the SplittingStep coefficients by name
drreynolds Jul 18, 2025
4abe737
More unused variables
drreynolds Jul 18, 2025
5390b77
Fixed unused macro (I didn't even realize that was now cause for errors)
drreynolds Jul 18, 2025
d54f74f
Added missing static
drreynolds Jul 18, 2025
729e4ed
Updated answers submodule commit
drreynolds Jul 18, 2025
3f3c484
Fixed sanitizer CI issues
drreynolds Jul 18, 2025
a9b451d
formatting
drreynolds Jul 18, 2025
1cc17fd
Removed unused variables
drreynolds Jul 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion examples/arkode/C_serial/ark_analytic.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ static int check_ans(N_Vector y, sunrealtype t, sunrealtype rtol,
sunrealtype atol);

/* Main Program */
int main(void)
int main(int argc, char* argv[])
{
/* general problem parameters */
sunrealtype T0 = SUN_RCONST(0.0); /* initial time */
Expand Down Expand Up @@ -130,6 +130,10 @@ int main(void)
flag = ARKodeSetLinear(arkode_mem, 0);
if (check_flag(&flag, "ARKodeSetLinear", 1)) { return 1; }

/* Override any current settings with command-line options */
flag = ARKodeSetFromCommandLine(arkode_mem, "", argc, argv);
if (check_flag(&flag, "ARKodeSetFromCommandLine", 1)) { return 1; }

/* Open output stream for results, output comment line */
UFID = fopen("solution.txt", "w");
fprintf(UFID, "# t u\n");
Expand Down
4 changes: 4 additions & 0 deletions include/arkode/arkode.h
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ typedef enum
* Shared API routines
* -------------------------- */

/* Command-line control over ARKODE options */
SUNDIALS_EXPORT int ARKodeSetFromCommandLine(void* arkode_mem, const char* arkid,
int argc, char* argv[]);

/* Resize and Reset functions */
SUNDIALS_EXPORT int ARKodeResize(void* arkode_mem, N_Vector ynew,
sunrealtype hscale, sunrealtype t0,
Expand Down
Loading