-
Notifications
You must be signed in to change notification settings - Fork 155
Command-line control over scalar-valued set routines #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
120 commits
Select commit
Hold shift + click to select a range
2e4a100
Initial implementation of command-line control over ARKODE inputs
drreynolds 4ee0ced
Added const qualifier
drreynolds 7fe32c7
Apply suggestions from code review
drreynolds 567d885
Additional updates based on PR feedback
drreynolds 834be77
Added const for char* argv[] to subsidiary functions
drreynolds 843b240
Converted separate arrays to arrays of structs
drreynolds 81da918
Removed const decorator from argv inputs to ARKodeSetFromCommandLine,…
drreynolds ccb3a0d
Updated swig interfaces
drreynolds 3ff1574
Updated handling of errors when setting command-line arguments
drreynolds 5697de0
Updated ARKodeSetFromCommandLine to include an input 'arkid' that sho…
drreynolds 229c013
Updated swig interfaces
drreynolds 6d55e2d
Updated comment
drreynolds f88f66b
Updated formatting
drreynolds 9a552b9
Updated type for 'offset' to size_t to avoid conversion warnings/errors
drreynolds 62fecac
Apply suggestions from code review to automatically determine the num…
drreynolds 3eece32
Moved command-line input control to a separate file
drreynolds 17000e9
Updated handling of arkid input according to Steven's suggestion
drreynolds cbdaf2d
Updated includes now that cli interface is separated into a new file
drreynolds 44abb69
Added support for a new writeparameters command-line option, that wil…
drreynolds d65c219
Added function pointer for stepper-specific setfromcommandline functi…
drreynolds 60e3287
Added placeholder for ARKStep command-line processing (needs to be fi…
drreynolds 20e3232
Moved typedefs and general CLI utility routines up to SUNDIALS level,…
drreynolds 00991b5
Added command-line support to ARKStep
drreynolds a451341
Added command-line support to ERKStep
drreynolds 4880960
Added command-line support to SPRKStep and LSRKStep
drreynolds 961ed95
Added command-line support to MRIStep
drreynolds dd29861
Added command-line support to ark_kpr_mri.c for manual testing (passes)
drreynolds c175f56
Formatting
drreynolds b1fd734
Update src/arkode/arkode_cli.c
drreynolds d24a61a
Moved sundials_cli.h to src/sundials
drreynolds a0e5a17
Added ARKODE command-line control for linear solver set routines
drreynolds 459c58b
Added command-line control for CVODE
drreynolds d35479e
Added command-line control for CVODE
drreynolds 3a9a4ff
Added command-line control to CVODES
drreynolds 0c525e0
Added command-line control to IDA
drreynolds 8cc31f8
Added command-line control to IDAS
drreynolds d67bd22
Added command-line control to KINSOL
drreynolds 7db9133
Regenerated SWIG interfaces
drreynolds f747539
Formatting
drreynolds 1e6f96f
Applied spelling 'patch', that forced me to rename the long-int varia…
drreynolds cefc028
Added command-line control over SUNAdaptControllers
drreynolds b276550
Updated Swig interfaces
drreynolds f0cc756
Added command-line control over SUNLinearSolvers
drreynolds 1aced24
Fixed unused variable warning/error
drreynolds 29dfdce
Fixed unused variable warning/error
drreynolds 7fc20d1
formatting
drreynolds 63466df
Minor updates to hopeflly fix build on Windows/MSVC
drreynolds 16dfb96
Fixed missing include
drreynolds e35b1bf
Fixed missing include
drreynolds 575a86f
formatting
drreynolds 4ab74ca
Added missing SUNDIALS_EXPORT
drreynolds e4c57e0
Removed explicit cast that I introduced when trying to resolve Window…
drreynolds bb35002
formatting
drreynolds ef344c6
Added documentation for command-line control
drreynolds dc04506
Merged upstream changes
drreynolds 5793e29
Formatting
drreynolds e8dad98
Fixed quotation marks
drreynolds af73d8e
Documented command-line control over SUNAdaptController and SUNLinear…
drreynolds 3b41971
Removed SetFromCommandLine functions from linear solver and adaptivit…
drreynolds 4528bdf
Updated commands to remove SetFromCommandLine routines from some SWIG…
drreynolds 1882fec
Fixed missing {
drreynolds 5596787
Formatting
drreynolds 431a12b
Merge ../develop into feature/commandline
drreynolds 09e2303
Applied all minor suggestions from code review. Will start on larger …
drreynolds a1f74ce
Converted other integrator cli files to SUNErrCode
drreynolds 87c67ae
Converted 'static struct sunKey*' to 'static const struct sunKey*'
drreynolds 4f1f51c
Converted *SetFromCommandLine routines to treat NULL-valued IDs as th…
drreynolds 2728204
Removed 'const' from offset argument to ARKODE stepper-specific SetFr…
drreynolds c82a954
Additional fixes to address PR reviews
drreynolds dcb9451
Merged in changes from develop
drreynolds 73abfba
Applied formatting patch
drreynolds 297a31e
Fixed merge issue
drreynolds e2fbeb8
Added utility routines to loop through lists of arguments to call set…
drreynolds a1b96ef
Added more CI tests for command-line arguments
drreynolds 5904780
Added documentation for command-line processing to the developer guide
drreynolds 946ce32
Removed unused CLI utility routines
drreynolds b4f8c88
Added additional notes to the SUNAdaptController documentation
drreynolds 8174b55
Added note on command-line options to the developer guide checklist
drreynolds bbf2cc2
Merge branch 'develop' into feature/commandline
gardner48 ddf872f
fix spelling
gardner48 49232f7
apply formatting
gardner48 97b61b6
include errors impl header, remove unused variables
gardner48 a0a97d1
add missing output file
gardner48 ad8c547
add new output files
gardner48 87d9f17
update answers submodule
gardner48 c31a78c
Merge branch 'develop' into feature/commandline
gardner48 26e8863
Merge branch 'develop' into feature/commandline
gardner48 b0ba553
update answers submodule
gardner48 ce0b020
update answers submodule
gardner48 534c4d9
apply formatting
gardner48 619d5e2
update answers submodule
gardner48 4ff4273
Applied some minor recommendations
drreynolds e72d741
Applied some minor recommendations to the ARKODE docs, and made some …
drreynolds 7b11a0c
Applied multiple minor recommendations from PR review
drreynolds 57d88e7
Converted *SetFromCommandLine routines into *SetOptions routines (as …
drreynolds e2e8cfc
formatting
drreynolds 277e3ff
swig
drreynolds 86798ab
Fixed swig ignores for new function names
drreynolds c4080f9
Swig
drreynolds 522a960
Fixed missing 'static'
drreynolds a8241f2
formatting
drreynolds f733ef1
Moved logic to set command-line prefixes outside of argument loop
drreynolds b1f3438
formatting
drreynolds 4cebebc
removed unused variables
drreynolds 827e9c4
removed unused variables
drreynolds ec435bb
Updated handling of command-line prefixes
drreynolds 887967e
formatting
drreynolds e573a0e
Updated documentation to clarify the role of the '.' separator betwee…
drreynolds 2e3660b
Updated ark_analytic.c example to output solver parameters _after_ co…
drreynolds 78c7040
Updated idaAnalytic.c example to omit output of tolerances
drreynolds b5c1259
Updated idasAnalytic_mels to output the initial time step size taken
drreynolds e5f9b48
Removed command-line control over deprecated SPRKStepUseCompensatedSu…
drreynolds 35b1f5d
Added command-line control over the SplittingStep coefficients by name
drreynolds 4abe737
More unused variables
drreynolds 5390b77
Fixed unused macro (I didn't even realize that was now cause for errors)
drreynolds d54f74f
Added missing static
drreynolds 729e4ed
Updated answers submodule commit
drreynolds 3f3c484
Fixed sanitizer CI issues
drreynolds a9b451d
formatting
drreynolds 1cc17fd
Removed unused variables
drreynolds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.