Fixes for MRI-HTol adaptivity -- added missing scaling to accumulated… #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error, and allowed 'fuzz factor' to also be used when assessing tstop criteria at the start of a step (already used at the end of a step)
drreynolds
requested review from
balos1,
gardner48 and
cswoodward
as code owners
gardner48
requested changes
Sep 15, 2025
Co-authored-by: David Gardner <gardner48@llnl.gov>
gardner48
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for MRI-HTol adaptivity -- added missing scaling to accumulated error, and allowed 'fuzz factor' to also be used when assessing tstop criteria at the start of a step (already used at the end of a step)