updated default dee_rel_tol #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggul
requested review from
balos1,
gardner48,
cswoodward and
drreynolds
as code owners
drreynolds
previously approved these changes
Sep 24, 2025
gardner48
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dee_rel_tolis currently set to0.01, while the eigensafety factor used in STS methods is1.01. These choices result in an uncovered region.Assume
λ_est = 0.99 x λ_true. After multiplying by the eigensafety factor of1.01, we obtaineigensafety x λ_est = 1.01 x 0.99 x λ_true = 0.9999 x λ_trueThis may not cause a problem for systems with small dominant eigenvalues. However, as the dominant eigenvalue increases (say around 10^4-ish), this choice might lead to instability due to wrong number of stages employed.
To address this issue, this PR shrinks the
dee_rel_tolby half.