From 885ac752b4635d735083ee3379588a8ab6fcea1a Mon Sep 17 00:00:00 2001 From: maggul Date: Tue, 23 Sep 2025 14:28:06 -0500 Subject: [PATCH 1/3] updated default dee rel_tol --- doc/shared/sundomeigest/SUNDomEigEst_Power.rst | 4 ++-- examples/arkode/CXX_lapack/ark_heat2D_lsrk_domeigest.cpp | 2 +- examples/arkode/C_serial/ark_analytic_lsrk_domeigest.c | 2 +- src/sundomeigest/power/sundomeigest_power.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/shared/sundomeigest/SUNDomEigEst_Power.rst b/doc/shared/sundomeigest/SUNDomEigEst_Power.rst index abc232b634..6e97a561ec 100644 --- a/doc/shared/sundomeigest/SUNDomEigEst_Power.rst +++ b/doc/shared/sundomeigest/SUNDomEigEst_Power.rst @@ -85,7 +85,7 @@ routines: need too tight tolerances and consider a safety factor, and (2) an early (less costly) termination will be a good indicator whether the power iteration is compatible. - :param rel_tol: relative tolerance for convergence checks (default 0.01). A + :param rel_tol: relative tolerance for convergence checks (default 0.005). A value :math:`\leq 0` will result in the default value. The default has been found to small enough for many internal applications. @@ -149,7 +149,7 @@ information: * ``num_ATimes`` - number of calls to the ``ATimes`` function, -* ``rel_tol`` - relative tolerance for the convergence criteria (default is 0.01), +* ``rel_tol`` - relative tolerance for the convergence criteria (default is 0.005), * ``res`` - the residual from the last :c:func:`SUNDomEigEstimator_Estimate` call. diff --git a/examples/arkode/CXX_lapack/ark_heat2D_lsrk_domeigest.cpp b/examples/arkode/CXX_lapack/ark_heat2D_lsrk_domeigest.cpp index a182e673d5..11f81f9491 100644 --- a/examples/arkode/CXX_lapack/ark_heat2D_lsrk_domeigest.cpp +++ b/examples/arkode/CXX_lapack/ark_heat2D_lsrk_domeigest.cpp @@ -602,7 +602,7 @@ static int InitUserData(UserData* udata) udata->dee_num_succ_wups = 5; udata->dee_max_iters = 100; udata->dee_krylov_dim = 3; - udata->dee_reltol = 0.01; + udata->dee_reltol = 0.005; // Timing variables udata->timing = false; diff --git a/examples/arkode/C_serial/ark_analytic_lsrk_domeigest.c b/examples/arkode/C_serial/ark_analytic_lsrk_domeigest.c index 4b96bbf6da..2ca1c03f89 100644 --- a/examples/arkode/C_serial/ark_analytic_lsrk_domeigest.c +++ b/examples/arkode/C_serial/ark_analytic_lsrk_domeigest.c @@ -125,7 +125,7 @@ int main(int argc, char* argv[]) SUNDomEigEstimator DEE = NULL; /* domeig estimator object */ sunindextype max_iters = 100; /* max number of power iterations (PI)*/ sunindextype numwarmup = 10; /* number of preprocessing warmups */ - sunrealtype rel_tol = SUN_RCONST(1.0e-2); /* relative error for PI*/ + sunrealtype rel_tol = SUN_RCONST(5.0e-3); /* relative error for PI*/ N_Vector q = NULL; /* random initial eigenvector */ /* Create the SUNDIALS context object for this simulation */ diff --git a/src/sundomeigest/power/sundomeigest_power.c b/src/sundomeigest/power/sundomeigest_power.c index 53b7101f2e..47a83b0857 100644 --- a/src/sundomeigest/power/sundomeigest_power.c +++ b/src/sundomeigest/power/sundomeigest_power.c @@ -31,7 +31,7 @@ #define DEE_NUM_OF_WARMUPS_PI_DEFAULT 100 /* Default Power Iteration parameters */ -#define DEE_TOL_DEFAULT SUN_RCONST(0.01) +#define DEE_TOL_DEFAULT SUN_RCONST(0.005) #define DEE_MAX_ITER_DEFAULT 100 /* From 23402404125e5d882fd37b4d13e6e01b5d12ef2e Mon Sep 17 00:00:00 2001 From: maggul Date: Tue, 23 Sep 2025 16:20:04 -0500 Subject: [PATCH 2/3] update the output files --- examples/arkode/CXX_lapack/ark_heat2D_lsrk_domeigest.out | 2 +- test/answers | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/arkode/CXX_lapack/ark_heat2D_lsrk_domeigest.out b/examples/arkode/CXX_lapack/ark_heat2D_lsrk_domeigest.out index e0e27a611a..cfc42a9db8 100644 --- a/examples/arkode/CXX_lapack/ark_heat2D_lsrk_domeigest.out +++ b/examples/arkode/CXX_lapack/ark_heat2D_lsrk_domeigest.out @@ -29,7 +29,7 @@ dee num_succ_wups = 5 dee_max_iters = 100 dee_krylov_dim = 3 - dee_reltol = 0.01 + dee_reltol = 0.005 ------------------------------------ t ||u||_rms max error diff --git a/test/answers b/test/answers index 9f1069e566..6fb07e37ab 160000 --- a/test/answers +++ b/test/answers @@ -1 +1 @@ -Subproject commit 9f1069e566d24c0c7be610441188efc846f40b6b +Subproject commit 6fb07e37ab21153fc2582dec766898aa75b3372c From 927ee5c4c6ef0094432c203509c606ddafd25489 Mon Sep 17 00:00:00 2001 From: "David J. Gardner" Date: Tue, 23 Sep 2025 18:14:30 -0700 Subject: [PATCH 3/3] update answers submodule --- test/answers | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/answers b/test/answers index 6fb07e37ab..779e974c80 160000 --- a/test/answers +++ b/test/answers @@ -1 +1 @@ -Subproject commit 6fb07e37ab21153fc2582dec766898aa75b3372c +Subproject commit 779e974c8095d8b3c2837edf56632a990714d669