Lv2 Fix invalid memory access if plugin did not load

JohannesLorenz · JohannesLorenz · commit 7808e0b92fdb · 2020-10-24T17:28:44.000+02:00
diff --git a/src/core/lv2/Lv2Proc.cpp b/src/core/lv2/Lv2Proc.cpp
@@ -396,9 +396,12 @@ void Lv2Proc::initPlugin()
 
 void Lv2Proc::shutdownPlugin()
 {
-	lilv_instance_deactivate(m_instance);
-	lilv_instance_free(m_instance);
-	m_instance = nullptr;
+	if (m_valid)
+	{
+		lilv_instance_deactivate(m_instance);
+		lilv_instance_free(m_instance);
+		m_instance = nullptr;
+	}
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -396,9 +396,12 @@ void Lv2Proc::initPlugin()`
`396`	`396`
`397`	`397`	`void Lv2Proc::shutdownPlugin()`
`398`	`398`	`{`
`399`		`- lilv_instance_deactivate(m_instance);`
`400`		`- lilv_instance_free(m_instance);`
`401`		`- m_instance = nullptr;`
	`399`	`+ if (m_valid)`
	`400`	`+ {`
	`401`	`+ lilv_instance_deactivate(m_instance);`
	`402`	`+ lilv_instance_free(m_instance);`
	`403`	`+ m_instance = nullptr;`
	`404`	`+ }`
`402`	`405`	`}`
`403`	`406`
`404`	`407`