Context menu for links

This patch implements a context menu for links. In the future, we could
even check for the modifiers and open links in new windows, or private
windows - but not today.

Author: diegoiast

BrowserWindow.cpp

@@ -282,9 +282,17 @@ void BrowserWindow::debug_request(String const& request, String const& argument)
 }
 
 void BrowserWindow::new_tab()
+{
+    auto tab = make<Tab>(this, m_webdriver_fd_passing_socket);
+    new_tab_with_url({});
+}
+
+void BrowserWindow::new_tab_with_url(const QUrl &url)
 {
     auto tab = make<Tab>(this, m_webdriver_fd_passing_socket);
     auto tab_ptr = tab.ptr();
+    if (!url.isEmpty())
+        tab->navigate(url.toString());
     m_tabs.append(std::move(tab));
 
     if (m_current_tab == nullptr) {

BrowserWindow.h

@@ -32,6 +32,7 @@ public slots:
     void tab_title_changed(int index, QString const&);
     void tab_favicon_changed(int index, QIcon icon);
     void new_tab();
+    void new_tab_with_url(QUrl const&);
     void close_tab(int index);
     void close_current_tab();
     void open_next_tab();

Tab.cpp

@@ -10,12 +10,16 @@
 #include "Settings.h"
 #include "Utilities.h"
 #include <Browser/History.h>
-#include <QCoreApplication>
 #include <QFont>
 #include <QFontMetrics>
 #include <QPlainTextEdit>
+#include <QClipboard>
+#include <QFont>
+#include <QFontMetrics>
+#include <QGuiApplication>
 #include <QPoint>
 #include <QResizeEvent>
+#include <QUrl>
 
 extern String s_serenity_resource_root;
 extern Browser::Settings* s_settings;
@@ -93,6 +97,27 @@ Tab::Tab(BrowserWindow* window, int webdriver_fd_passing_socket)
         m_back_action->setEnabled(m_history.can_go_back());
         m_forward_action->setEnabled(m_history.can_go_forward());
     });
+
+    QObject::connect(m_view, &WebContentView::link_content_menu, [this] (QPoint &local_position, const QUrl& url, unsigned ){
+        auto global_position = this->mapToGlobal(local_position);
+        auto menu = QMenu();
+
+        auto copy_link_action = new QAction(tr("&Copy Link"));
+        auto open_link_in_tab_action = new QAction(tr("Open link in a &new tab"));
+
+        menu.addAction(open_link_in_tab_action);
+        menu.addAction(copy_link_action);
+        auto res = menu.exec(global_position);
+
+        if (res == copy_link_action) {
+            QClipboard *clipboard = QGuiApplication::clipboard();
+            clipboard->setText(url.toString());
+            qDebug() << "Copied to clipboard text:" << url.toString();
+        } else if (res == open_link_in_tab_action){
+            auto browser_window = static_cast<BrowserWindow*>(m_window);
+            return browser_window->new_tab_with_url(url);
+        }
+    });
     QObject::connect(m_location_edit, &QLineEdit::returnPressed, this, &Tab::location_edit_return_pressed);
     QObject::connect(m_view, &WebContentView::title_changed, this, &Tab::page_title_changed);
     QObject::connect(m_view, &WebContentView::favicon_changed, this, &Tab::page_favicon_changed);

Utilities.cpp

@@ -10,7 +10,9 @@
 #include <AK/LexicalPath.h>
 #include <AK/Platform.h>
 #include <LibCore/File.h>
+#include <LibGfx/Point.h>
 #include <QCoreApplication>
+#include <QPoint>
 
 String s_serenity_resource_root;
 
@@ -24,6 +26,16 @@ QString qstring_from_akstring(AK::String const& akstring)
     return QString::fromUtf8(akstring.characters(), akstring.length());
 }
 
+QUrl qurl_from_akurl(AK::URL const& akurl)
+{
+    return QUrl(qstring_from_akstring(akurl.to_string()));
+}
+
+QPoint qpoint_from_intpoint(Gfx::IntPoint const& position)
+{
+    return QPoint(position.x(), position.y());
+}
+
 void platform_init()
 {
 #ifdef AK_OS_ANDROID
@@ -45,3 +57,4 @@ void platform_init()
     }();
 #endif
 }
+

Utilities.h

@@ -6,11 +6,19 @@
 
 #pragma once
 
+#define AK_DONT_REPLACE_STD
+#include <AK/URL.h>
+#include <LibGfx/Forward.h>
 #include <AK/String.h>
 #include <QString>
+#include <QPoint>
+#include <QUrl>
 
 AK::String akstring_from_qstring(QString const&);
 QString qstring_from_akstring(AK::String const&);
+QUrl qurl_from_akurl(AK::URL const& akurl);
+QPoint qpoint_from_intpoint(Gfx::IntPoint const& position);
+
 void platform_init();
 
 extern String s_serenity_resource_root;

WebContentView.cpp

@@ -833,11 +833,13 @@ void WebContentView::notify_server_did_request_context_menu(Badge<WebContentClie
     (void)content_position;
 }
 
-void WebContentView::notify_server_did_request_link_context_menu(Badge<WebContentClient>, Gfx::IntPoint const& content_position, AK::URL const& url, String const&, unsigned)
+void WebContentView::notify_server_did_request_link_context_menu(Badge<WebContentClient>, Gfx::IntPoint const& content_position, AK::URL const& url, String const&, unsigned modifiers)
 {
-    // FIXME
-    (void)content_position;
-    (void)url;
+    auto view_offset = QPoint(horizontalScrollBar()->value(), verticalScrollBar()->value());
+    auto position_in_page = qpoint_from_intpoint(content_position);
+    auto position_in_view = position_in_page - view_offset;
+    auto qurl = qurl_from_akurl(url);
+    emit link_content_menu(position_in_view, qurl, modifiers);
 }
 
 void WebContentView::notify_server_did_request_image_context_menu(Badge<WebContentClient>, Gfx::IntPoint const& content_position, AK::URL const& url, String const&, unsigned, Gfx::ShareableBitmap const& bitmap)

WebContentView.h

@@ -169,6 +169,7 @@ class WebContentView final
     Gfx::IntRect maximize_window();
     Gfx::IntRect minimize_window();
     Gfx::IntRect fullscreen_window();
+    void link_content_menu(QPoint &local_position, const QUrl&, unsigned modifiers);
 
 private:
     void request_repaint();