Context menu for links

This patch implements a context menu for links. In the future, we could
even check for the modifiers and open links in new windows, or private
windows - but not today.

Author: diegoiast

BrowserWindow.cpp

@@ -244,9 +244,16 @@ void BrowserWindow::debug_request(String const& request, String const& argument)
 }
 
 void BrowserWindow::new_tab()
+{
+    new_tab_with_url(QUrl());
+}
+
+void BrowserWindow::new_tab_with_url(const QUrl &url)
 {
     auto tab = make<Tab>(this);
     auto tab_ptr = tab.ptr();
+    if (!url.isEmpty())
+        tab->navigate(url.toString());
     m_tabs.append(std::move(tab));
 
     if (m_current_tab == nullptr) {

BrowserWindow.h

@@ -31,6 +31,7 @@ public slots:
     void tab_title_changed(int index, QString const&);
     void tab_favicon_changed(int index, QIcon icon);
     void new_tab();
+    void new_tab_with_url(QUrl const&);
     void close_tab(int index);
     void close_current_tab();
     void open_next_tab();

PageClientLadybird.cpp

@@ -11,6 +11,7 @@
 #include "SimpleWebView.h"
 #include <LibCore/System.h>
 #include <LibGfx/Painter.h>
+#include <LibGfx/Point.h>
 #include <LibJS/Runtime/ConsoleObject.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/HTML/BrowsingContext.h>
@@ -162,8 +163,13 @@ void PageClientLadybird::page_did_request_context_menu(Gfx::IntPoint const&)
 {
 }
 
-void PageClientLadybird::page_did_request_link_context_menu(Gfx::IntPoint const&, AK::URL const&, String const&, unsigned)
+void PageClientLadybird::page_did_request_link_context_menu(Gfx::IntPoint const& position, AK::URL const& url, String const&, unsigned modifiers)
 {
+    auto view_offset = QPoint(m_view.horizontalScrollBar()->value(), m_view.verticalScrollBar()->value());
+    auto position_in_page = IntPoint_to_QPoint(position);
+    auto position_in_view = position_in_page - view_offset;
+    auto qurl = qurl_from_akurl(url);
+    emit m_view.link_content_menu(position_in_view, qurl, modifiers);
 }
 
 void PageClientLadybird::page_did_request_image_context_menu(Gfx::IntPoint const&, AK::URL const&, String const&, unsigned, Gfx::Bitmap const*)

SimpleWebView.cpp

@@ -59,6 +59,7 @@
 #include <QCursor>
 #include <QIcon>
 #include <QLineEdit>
+#include <QMenu>
 #include <QMessageBox>
 #include <QMouseEvent>
 #include <QPaintEvent>

SimpleWebView.h

@@ -67,6 +67,8 @@ class SimpleWebView final : public QAbstractScrollArea {
     void link_hovered(QString, int timeout = 0);
     void link_unhovered();
     void load_started(const URL&);
+    void link_content_menu(QPoint &local_position, const QUrl&, unsigned modifiers);
+    void loadStarted(const URL&);
     void title_changed(QString);
     void favicon_changed(QIcon);
 

Tab.cpp

@@ -9,11 +9,13 @@
 #include "BrowserWindow.h"
 #include "History.h"
 #include "Settings.h"
-#include <QCoreApplication>
+#include <QClipboard>
 #include <QFont>
 #include <QFontMetrics>
+#include <QGuiApplication>
 #include <QPoint>
 #include <QResizeEvent>
+#include <QUrl>
 
 extern String s_serenity_resource_root;
 extern Browser::Settings* s_settings;
@@ -76,6 +78,27 @@ Tab::Tab(BrowserWindow* window)
         m_back_action->setEnabled(m_history.can_go_back());
         m_forward_action->setEnabled(m_history.can_go_forward());
     });
+
+    QObject::connect(m_view, &SimpleWebView::link_content_menu, [this] (QPoint &local_position, const QUrl& url, unsigned ){
+        auto global_position = this->mapToGlobal(local_position);
+        auto menu = QMenu();
+
+        auto copy_link_action = new QAction(tr("Copy Link"));
+        auto open_link_in_tab_action = new QAction(tr("Open link in a new tab"));
+
+        menu.addAction(open_link_in_tab_action);
+        menu.addAction(copy_link_action);
+        auto res = menu.exec(global_position);
+
+        if (res == copy_link_action) {
+            QClipboard *clipboard = QGuiApplication::clipboard();
+            clipboard->setText(url.toString());
+            qDebug() << "Copied to clipboard text:" << url.toString();
+        } else if (res == open_link_in_tab_action){
+            auto browser_window = static_cast<BrowserWindow*>(m_window);
+            return browser_window->new_tab_with_url(url);
+        }
+    });
     QObject::connect(m_location_edit, &QLineEdit::returnPressed, this, &Tab::location_edit_return_pressed);
     QObject::connect(m_view, &SimpleWebView::title_changed, this, &Tab::page_title_changed);
     QObject::connect(m_view, &SimpleWebView::favicon_changed, this, &Tab::page_favicon_changed);

Utilities.cpp

@@ -4,9 +4,10 @@
  * SPDX-License-Identifier: BSD-2-Clause
  */
 
-#define AK_DONT_REPLACE_STD
 
 #include "Utilities.h"
+#include <LibGfx/Point.h>
+#include <QPoint>
 
 AK::String akstring_from_qstring(QString const& qstring)
 {
@@ -17,3 +18,16 @@ QString qstring_from_akstring(AK::String const& akstring)
 {
     return QString::fromUtf8(akstring.characters(), akstring.length());
 }
+
+QUrl qurl_from_akurl(AK::URL const& akurl)
+{
+    return QUrl(qstring_from_akstring(akurl.to_string()));
+}
+
+QPoint IntPoint_to_QPoint(Gfx::IntPoint const& position)
+{
+    auto p = QPoint();
+    p.setX(position.x());
+    p.setY(position.y());
+    return p;
+}

Utilities.h

@@ -6,8 +6,15 @@
 
 #pragma once
 
+#define AK_DONT_REPLACE_STD
+#include <AK/URL.h>
+#include <LibGfx/Forward.h>
 #include <AK/String.h>
 #include <QString>
+#include <QPoint>
+#include <QUrl>
 
 AK::String akstring_from_qstring(QString const&);
 QString qstring_from_akstring(AK::String const&);
+QUrl qurl_from_akurl(AK::URL const& akurl);
+QPoint IntPoint_to_QPoint(Gfx::IntPoint const& position);