Skip to content
This repository was archived by the owner on Dec 25, 2022. It is now read-only.

Commit cddcb9d

Browse files
MacDueAtkinsSJ
MacDue
authored and
AtkinsSJ
committed
Pass Gfx::IntPoint by value
1 parent f2f43da commit cddcb9d

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

‎WebContentView.cpp

+6-6
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,7 @@ void WebContentView::notify_server_did_request_scroll(Badge<WebContentClient>, i
743743
verticalScrollBar()->setValue(verticalScrollBar()->value() + y_delta);
744744
}
745745

746-
void WebContentView::notify_server_did_request_scroll_to(Badge<WebContentClient>, Gfx::IntPoint const& scroll_position)
746+
void WebContentView::notify_server_did_request_scroll_to(Badge<WebContentClient>, Gfx::IntPoint scroll_position)
747747
{
748748
horizontalScrollBar()->setValue(scroll_position.x());
749749
verticalScrollBar()->setValue(scroll_position.y());
@@ -761,7 +761,7 @@ void WebContentView::notify_server_did_request_scroll_into_view(Badge<WebContent
761761
}
762762
}
763763

764-
void WebContentView::notify_server_did_enter_tooltip_area(Badge<WebContentClient>, Gfx::IntPoint const& content_position, DeprecatedString const& tooltip)
764+
void WebContentView::notify_server_did_enter_tooltip_area(Badge<WebContentClient>, Gfx::IntPoint content_position, DeprecatedString const& tooltip)
765765
{
766766
auto widget_position = to_widget(content_position);
767767
QToolTip::showText(
@@ -828,20 +828,20 @@ void WebContentView::notify_server_did_request_refresh(Badge<WebContentClient>)
828828
emit refresh();
829829
}
830830

831-
void WebContentView::notify_server_did_request_context_menu(Badge<WebContentClient>, Gfx::IntPoint const& content_position)
831+
void WebContentView::notify_server_did_request_context_menu(Badge<WebContentClient>, Gfx::IntPoint content_position)
832832
{
833833
// FIXME
834834
(void)content_position;
835835
}
836836

837-
void WebContentView::notify_server_did_request_link_context_menu(Badge<WebContentClient>, Gfx::IntPoint const& content_position, AK::URL const& url, DeprecatedString const&, unsigned)
837+
void WebContentView::notify_server_did_request_link_context_menu(Badge<WebContentClient>, Gfx::IntPoint content_position, AK::URL const& url, DeprecatedString const&, unsigned)
838838
{
839839
// FIXME
840840
(void)content_position;
841841
(void)url;
842842
}
843843

844-
void WebContentView::notify_server_did_request_image_context_menu(Badge<WebContentClient>, Gfx::IntPoint const& content_position, AK::URL const& url, DeprecatedString const&, unsigned, Gfx::ShareableBitmap const& bitmap)
844+
void WebContentView::notify_server_did_request_image_context_menu(Badge<WebContentClient>, Gfx::IntPoint content_position, AK::URL const& url, DeprecatedString const&, unsigned, Gfx::ShareableBitmap const& bitmap)
845845
{
846846
// FIXME
847847
(void)content_position;
@@ -991,7 +991,7 @@ void WebContentView::notify_server_did_request_restore_window()
991991
emit restore_window();
992992
}
993993

994-
Gfx::IntPoint WebContentView::notify_server_did_request_reposition_window(Gfx::IntPoint const& position)
994+
Gfx::IntPoint WebContentView::notify_server_did_request_reposition_window(Gfx::IntPoint position)
995995
{
996996
return emit reposition_window(position);
997997
}

‎WebContentView.h

+10-10
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ class WebContentView final
5454
void load(AK::URL const&);
5555
void load_html(StringView html, AK::URL const&);
5656

57-
Function<void(Gfx::IntPoint const& screen_position)> on_context_menu_request;
57+
Function<void(Gfx::IntPoint screen_position)> on_context_menu_request;
5858
Function<void(const AK::URL&, DeprecatedString const& target, unsigned modifiers)> on_link_click;
59-
Function<void(const AK::URL&, Gfx::IntPoint const& screen_position)> on_link_context_menu_request;
60-
Function<void(const AK::URL&, Gfx::IntPoint const& screen_position, Gfx::ShareableBitmap const&)> on_image_context_menu_request;
59+
Function<void(const AK::URL&, Gfx::IntPoint screen_position)> on_link_context_menu_request;
60+
Function<void(const AK::URL&, Gfx::IntPoint screen_position, Gfx::ShareableBitmap const&)> on_image_context_menu_request;
6161
Function<void(const AK::URL&, DeprecatedString const& target, unsigned modifiers)> on_link_middle_click;
6262
Function<void(const AK::URL&)> on_link_hover;
6363
Function<void(DeprecatedString const&)> on_title_change;
@@ -115,9 +115,9 @@ class WebContentView final
115115
virtual void notify_server_did_request_cursor_change(Badge<WebContentClient>, Gfx::StandardCursor cursor) override;
116116
virtual void notify_server_did_change_title(Badge<WebContentClient>, DeprecatedString const&) override;
117117
virtual void notify_server_did_request_scroll(Badge<WebContentClient>, i32, i32) override;
118-
virtual void notify_server_did_request_scroll_to(Badge<WebContentClient>, Gfx::IntPoint const&) override;
118+
virtual void notify_server_did_request_scroll_to(Badge<WebContentClient>, Gfx::IntPoint) override;
119119
virtual void notify_server_did_request_scroll_into_view(Badge<WebContentClient>, Gfx::IntRect const&) override;
120-
virtual void notify_server_did_enter_tooltip_area(Badge<WebContentClient>, Gfx::IntPoint const&, DeprecatedString const&) override;
120+
virtual void notify_server_did_enter_tooltip_area(Badge<WebContentClient>, Gfx::IntPoint, DeprecatedString const&) override;
121121
virtual void notify_server_did_leave_tooltip_area(Badge<WebContentClient>) override;
122122
virtual void notify_server_did_hover_link(Badge<WebContentClient>, const AK::URL&) override;
123123
virtual void notify_server_did_unhover_link(Badge<WebContentClient>) override;
@@ -128,9 +128,9 @@ class WebContentView final
128128
virtual void notify_server_did_request_navigate_back(Badge<WebContentClient>) override;
129129
virtual void notify_server_did_request_navigate_forward(Badge<WebContentClient>) override;
130130
virtual void notify_server_did_request_refresh(Badge<WebContentClient>) override;
131-
virtual void notify_server_did_request_context_menu(Badge<WebContentClient>, Gfx::IntPoint const&) override;
132-
virtual void notify_server_did_request_link_context_menu(Badge<WebContentClient>, Gfx::IntPoint const&, const AK::URL&, DeprecatedString const& target, unsigned modifiers) override;
133-
virtual void notify_server_did_request_image_context_menu(Badge<WebContentClient>, Gfx::IntPoint const&, const AK::URL&, DeprecatedString const& target, unsigned modifiers, Gfx::ShareableBitmap const&) override;
131+
virtual void notify_server_did_request_context_menu(Badge<WebContentClient>, Gfx::IntPoint) override;
132+
virtual void notify_server_did_request_link_context_menu(Badge<WebContentClient>, Gfx::IntPoint, const AK::URL&, DeprecatedString const& target, unsigned modifiers) override;
133+
virtual void notify_server_did_request_image_context_menu(Badge<WebContentClient>, Gfx::IntPoint, const AK::URL&, DeprecatedString const& target, unsigned modifiers, Gfx::ShareableBitmap const&) override;
134134
virtual void notify_server_did_request_alert(Badge<WebContentClient>, DeprecatedString const& message) override;
135135
virtual void notify_server_did_request_confirm(Badge<WebContentClient>, DeprecatedString const& message) override;
136136
virtual void notify_server_did_request_prompt(Badge<WebContentClient>, DeprecatedString const& message, DeprecatedString const& default_) override;
@@ -150,7 +150,7 @@ class WebContentView final
150150
virtual void notify_server_did_update_cookie(Badge<WebContentClient>, AK::URL const& url, Web::Cookie::Cookie const& cookie) override;
151151
virtual void notify_server_did_update_resource_count(i32 count_waiting) override;
152152
virtual void notify_server_did_request_restore_window() override;
153-
virtual Gfx::IntPoint notify_server_did_request_reposition_window(Gfx::IntPoint const&) override;
153+
virtual Gfx::IntPoint notify_server_did_request_reposition_window(Gfx::IntPoint) override;
154154
virtual Gfx::IntSize notify_server_did_request_resize_window(Gfx::IntSize) override;
155155
virtual Gfx::IntRect notify_server_did_request_maximize_window() override;
156156
virtual Gfx::IntRect notify_server_did_request_minimize_window() override;
@@ -171,7 +171,7 @@ class WebContentView final
171171
void navigate_forward();
172172
void refresh();
173173
void restore_window();
174-
Gfx::IntPoint reposition_window(Gfx::IntPoint const&);
174+
Gfx::IntPoint reposition_window(Gfx::IntPoint);
175175
Gfx::IntSize resize_window(Gfx::IntSize);
176176
Gfx::IntRect maximize_window();
177177
Gfx::IntRect minimize_window();

0 commit comments

Comments
 (0)