Skip to content

Great job! Thank you. I wish to know why you decided to resize the images to 500 pixels. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chatulBamagafaeim opened this issue Nov 10, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@chatulBamagafaeim
Copy link

chatulBamagafaeim commented Nov 10, 2021

Thank you for your great code here.
When I tried to use Google Vision API - the results wasn't accurate because of the resize.
Is it possible to disable the resize?
Changing the width by hand cause the algorithm to be less effective.
Thanks.

@LakshyaKhatri
Copy link
Owner

LakshyaKhatri commented Nov 16, 2021

Hey @chatulBamagafaeim! I think we can. Currently the resizing code is directly applied on the images being saved to the database. We can instead store multiple version of the image as per our need. Although, this will require some work. I would appreciate if you could propose something.

Again, I think it's okay to pass inaccurate text to the scrappers. Since scrapper is doing a google search, it will find the correct book eventually.

@LakshyaKhatri LakshyaKhatri added the enhancement New feature or request label Nov 18, 2021
@chatulBamagafaeim
Copy link
Author

I increased the numbers from 500px to 1500px. Also increased this https://github.com/LakshyaKhatri/Bookshelf-Reader-API/blob/master/spine_detection.py#L47 to 65.
It worked fine but I think it's not enough.
What do you think?

@LakshyaKhatri
Copy link
Owner

Thanks for investing and digging deeper in it. At that time 500px worked for me. I'm thinking of going with having different versions of image (155px, 500px, 1500px and so on...). This will give people more control over what kind of result they want.

And I see, the overlapping lines thing is also depending on the image size, probably hardcoding values for each size will do the job for now. We can later find something more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants