Skip to content

Conversation

@MowFord
Copy link
Contributor

@MowFord MowFord commented Sep 12, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Inching closer towards perfect (and resolving #5495) this PR splits the :spawnPet() function to only handle player entities, and moves the mob logic into a different function that only prepares a pet for summoning. Logic to report incorrect usage:

image

This PR should have a net behavior change of zero. Except perhaps that the copyconfrontation is moved out of requiring a petid when preparing a mob's pet. It's possible there's some edge case resolved by this, but I would imagine the only thing affected would have been summoner pets, which already pass a petid.

Steps to test these changes

  • Go to smn, pup, bst, drg mobs, see they still summon pets
    • note that bst mobs were getting a death listener to remove their pet if it isn't engaged, this is not necessary as of this PR
  • be those jobs yourself, see you can still summon pets

@MowFord MowFord force-pushed the pet_spawn_segregation branch from 9fdb358 to 7254967 Compare September 12, 2025 02:14
@MowFord
Copy link
Contributor Author

MowFord commented Sep 12, 2025

One regression i noticed with this is that pets spawn all around the mob, instead of behind them as before. Going to push a quick update to fix that

Edit: done. Will move this spawn position logic into xi.mob.callPets on the next iteration

@MowFord MowFord force-pushed the pet_spawn_segregation branch from 7254967 to 420f81d Compare September 12, 2025 14:28
@MowFord MowFord force-pushed the pet_spawn_segregation branch 2 times, most recently from 0212a75 to f5137ef Compare September 20, 2025 01:58
@MowFord MowFord force-pushed the pet_spawn_segregation branch from f5137ef to 90cf60d Compare September 20, 2025 02:03
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

This PR has been automatically marked as stale because
it has not had recent activity. It will be closed if no
further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants