[cpp/lua] Split player and mob pet spawn bindings #8043
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Inching closer towards perfect (and resolving #5495) this PR splits the
:spawnPet()function to only handle player entities, and moves the mob logic into a different function that only prepares a pet for summoning. Logic to report incorrect usage:This PR should have a net behavior change of zero. Except perhaps that the copyconfrontation is moved out of requiring a petid when preparing a mob's pet. It's possible there's some edge case resolved by this, but I would imagine the only thing affected would have been summoner pets, which already pass a petid.
Steps to test these changes