Merge pull request #31 from LangMem/improve/some_improve

refactor: simplify array checks for embeddings and content, enhancing…

Author: Aias00

mem4j-core/src/main/java/io/github/mem4j/embeddings/DashScopeEmbeddingService.java

@@ -86,7 +86,7 @@ public Double[] embed(String text) {
 			JsonNode responseJson = objectMapper.readTree(response.getBody());
 			JsonNode embeddings = responseJson.path("output").path("embeddings");
 
-			if (embeddings.isArray() && embeddings.size() > 0) {
+			if (embeddings.isArray() && !embeddings.isEmpty()) {
 				JsonNode firstEmbedding = embeddings.get(0);
 				JsonNode embeddingArray = firstEmbedding.path("embedding");
 

mem4j-core/src/main/java/io/github/mem4j/memory/Memory.java

@@ -226,6 +226,8 @@ private List<String> extractMemories(List<Message> messages, boolean infer) {
 
 		String prompt = String.format("""
 				Extract key memories from this conversation. Focus on:
+				- Keep the original language and tone
+				- Be concise and specific
 				- Important facts about the user
 				- User preferences and behaviors
 				- Significant events or experiences

mem4j-core/src/main/java/io/github/mem4j/util/AnthropicValidator.java

@@ -319,7 +319,7 @@ private String makeRequest(Map<String, Object> requestBody) throws Exception {
 		JsonNode responseJson = objectMapper.readTree(response.getBody());
 		JsonNode content = responseJson.path("content");
 
-		if (content.isArray() && content.size() > 0) {
+		if (content.isArray() && !content.isEmpty()) {
 			JsonNode firstContent = content.get(0);
 			return firstContent.path("text").asText();
 		}

mem4j-core/src/main/java/io/github/mem4j/vectorstores/MilvusVectorStoreService.java

@@ -275,9 +275,7 @@ public List<MemoryItem> search(Double[] queryEmbedding, Map<String, Object> filt
 			String searchExpr = buildSearchExpression(filters);
 
 			// 转换查询向量为Float类型
-			List<Float> queryVector = Arrays.stream(queryEmbedding)
-				.map(Double::floatValue)
-				.collect(Collectors.toList());
+			List<Float> queryVector = Arrays.stream(queryEmbedding).map(Double::floatValue).toList();
 
 			// 构建搜索参数
 			SearchParam searchParam = SearchParam.newBuilder()
@@ -306,7 +304,7 @@ public List<MemoryItem> search(Double[] queryEmbedding, Map<String, Object> filt
 				// 获取搜索结果的字段数据
 				List<FieldData> fieldsData = searchResults.getResults().getFieldsDataList();
 
-				if (fieldsData != null && !fieldsData.isEmpty()) {
+				if (!fieldsData.isEmpty()) {
 					// 创建字段映射
 					Map<String, List<Object>> fieldMap = new HashMap<>();